Skip to content

Add picture login icon#1221

Open
AllanOXDi wants to merge 2 commits intolearningequality:developfrom
AllanOXDi:picture-login-icon
Open

Add picture login icon#1221
AllanOXDi wants to merge 2 commits intolearningequality:developfrom
AllanOXDi:picture-login-icon

Conversation

@AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Mar 20, 2026

Description

This PR adds set of 24 icons to support picture login work.

Issue addressed

#1215

Before/after screenshots

image

Changelog

  • Description: adds set of 24 icons to support picture login work.
  • Products impact: Kolibri
  • Addresses: Add new icons for picture login Kolibri feature #1215
  • Components:
  • **Breaking:**N/A
  • Impacts a11y: NO
  • Guidance: Test this icon on Kolibri by running pnpm devserver-with-kds /path to verify if they render correctly

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

dogStandard: {
icon: require('./precompiled-icons/le/dogStandard.vue').default,
picturePasscode: true,
defaultSize: '4em',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added default sizing to the standard icon because their label text at the bottom occupies part of the 84px viewBox, making the illustration portion look smaller.

Copy link
Member

@LianaHarris360 LianaHarris360 Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this defaultSize property still needed, even though the label text isn't there anymore?

Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons have been correctly added to the KDS Icons documentation page, but the standard icons are missing from the custom-icons/ folder, they should be added there as well. I'm not sure how, but they are correctly referenced within the precompiled-icons folder. Also requested a minor name change for the grouped picture login icons.

/>
</div>

<h3 v-if="picturePasscodes.length">Picture Passcodes</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this "Picture Passcodes" heading to "Picture Login Icons" instead? This is correct as stated in the issue, but in Kolibri these icons are referenced as Picture Login/Password icons, so, in hindsight, I think the naming should be consistent in KDS as well. Same with the definitions in the iconDefinitions.js file, let's change "picturePasscode" to "pictureLogin"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants