Conversation
lib/KIcon/iconDefinitions.js
Outdated
| dogStandard: { | ||
| icon: require('./precompiled-icons/le/dogStandard.vue').default, | ||
| picturePasscode: true, | ||
| defaultSize: '4em', |
There was a problem hiding this comment.
Added default sizing to the standard icon because their label text at the bottom occupies part of the 84px viewBox, making the illustration portion look smaller.
There was a problem hiding this comment.
Is this defaultSize property still needed, even though the label text isn't there anymore?
8da98b8 to
c14ae13
Compare
97b15f4 to
c1d477b
Compare
c1d477b to
bcacff6
Compare
LianaHarris360
left a comment
There was a problem hiding this comment.
The icons have been correctly added to the KDS Icons documentation page, but the standard icons are missing from the custom-icons/ folder, they should be added there as well. I'm not sure how, but they are correctly referenced within the precompiled-icons folder. Also requested a minor name change for the grouped picture login icons.
| /> | ||
| </div> | ||
|
|
||
| <h3 v-if="picturePasscodes.length">Picture Passcodes</h3> |
There was a problem hiding this comment.
Can you rename this "Picture Passcodes" heading to "Picture Login Icons" instead? This is correct as stated in the issue, but in Kolibri these icons are referenced as Picture Login/Password icons, so, in hindsight, I think the naming should be consistent in KDS as well. Same with the definitions in the iconDefinitions.js file, let's change "picturePasscode" to "pictureLogin"
Description
This PR adds set of 24 icons to support picture login work.
Issue addressed
#1215
Before/after screenshots
Changelog
pnpm devserver-with-kds /pathto verify if they render correctlyTesting checklist
Reviewer guidance