Wrap iconAfter slot in same span.icon-container on icon slot#1219
Open
nucleogenesis wants to merge 1 commit intolearningequality:developfrom
Open
Wrap iconAfter slot in same span.icon-container on icon slot#1219nucleogenesis wants to merge 1 commit intolearningequality:developfrom
iconAfter slot in same span.icon-container on icon slot#1219nucleogenesis wants to merge 1 commit intolearningequality:developfrom
Conversation
vertical spacing being inconsistent demands separate styles when tweaking the icon's position by having to address the `iconAfter` differently than the `icon`
nucleogenesis
requested a deployment
to
percy_tests
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found while trying to setup some
[<- Prev] [Next ->]type buttons that only theiconslot had a wrapping span w/ a class that sets atopvalue andrelativeposition but theiconAfterdoes not have it. This meant that I'd need to have two separate classes with two separate values to align the icons but fixing this makes that easier and makes KButton more consistent.(Possibly) Breaking changes in Kolibri
Here is everywhere I found that uses the
#iconAfterprop - some definitely have applied styles to address the problem that this PR fixes and would likely be able to be simplified quite a bit.Changelog
iconAfterslot in samespan.icon-containerthaticonslot is already wrapped in.#iconAfterslot is used in Kolibri and update styles as neededTesting checklist
Reviewer guidance
Comments