chore(ts-sdk): migrate to eslint 10 and @typescript-eslint v8#81
Open
adnanrhussain wants to merge 1 commit into
Open
chore(ts-sdk): migrate to eslint 10 and @typescript-eslint v8#81adnanrhussain wants to merge 1 commit into
adnanrhussain wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR consolidates the TypeScript SDK’s linting-toolchain upgrades by migrating to ESLint v10 and @typescript-eslint v8, including the required move from legacy .eslintrc to ESLint flat config so dependency/peer-dep conflicts can be resolved cleanly.
Changes:
- Upgraded
eslintto v10 and@typescript-eslint/{eslint-plugin,parser}to v8, adding flat-config dependencies (@eslint/js,globals). - Replaced
.eslintrc.cjswitheslint.config.jsand updated thelintscript for ESLint 9+ CLI semantics. - Removed now-unused
eslint-disabledirectives that ESLint v10 flags as unused; disabled baseno-redeclareto avoid TS type/value false positives.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdks/typescript/src/batch/evaluator.ts | Removes an unused eslint-disable directive now reported by ESLint v10. |
| sdks/typescript/src/batch/csv.ts | Removes an unused eslint-disable directive now reported by ESLint v10. |
| sdks/typescript/package.json | Bumps ESLint + TypeScript-ESLint deps, adds flat-config deps, updates lint script. |
| sdks/typescript/package-lock.json | Lockfile updates for the dependency upgrades. |
| sdks/typescript/eslint.config.js | Introduces ESLint flat config for TS + Node globals and TS-eslint rules. |
| sdks/typescript/.eslintrc.cjs | Removes legacy ESLint config (flat-config migration). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+17
| ecmaVersion: 2022, | ||
| sourceType: 'module', | ||
| project: './tsconfig.json', | ||
| tsconfigRootDir: import.meta.dirname, | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot opened three PRs that individually can't merge because they share a peer-dep conflict (
@typescript-eslint/eslint-plugin@6only supportseslint@^7 || ^8, blocking the ESLint 10 bump):ESLint 10 also removes the legacy
.eslintrcconfig format entirely, so the bump requires a flat-config migration as well. This PR does all four pieces in one coordinated change so the upgrade can actually land.(Older variants of the same bumps — #45, #54, #55, #56 — are superseded and will close out automatically.)
Changes
eslint8.56 → 10.4,@typescript-eslint/{eslint-plugin,parser}6.19 → 8.59 (latest stable for all)@eslint/jsandglobals(required by flat config).eslintrc.cjswitheslint.config.js(flat config)lintscript:eslint src tests --ext .ts→eslint "src/**/*.ts" "tests/**/*.ts"(--extremoved in ESLint 9+)no-redeclarerule (doesn't understand TS type/value pattern used in zod schemas)eslint-disabledirectives that v10 correctly reports as unusedTesting
All gates green locally:
npm run lintnpm run typechecknpm run buildnpm run test:unitnpm run test:coverage