Fix GCC-style asm %= unique ID translation to LLVM ${:uid} #5037
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC inline assembly uses %= to generate a unique ID for each asm
statement, useful for creating unique labels. The existing code
translated this to $= which is not valid LLVM inline asm syntax.
This changes the translation to use ${:uid} which is the correct
LLVM syntax for generating unique IDs.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
CyberShadow
force-pushed
the
fix-gcc-asm-unique-id
branch
from
0f4b61a to
26ba6be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLM disclosure: this entire PR is AI-generated. It might be OK, or it might be slop. The fix looks sensible on the surface, and it passes the test suite, however, so does most slop in general.
This PR doesn't fix any problem I'm seeing; it's just a problem Claude noticed while investigating #4294.
GCC inline assembly uses %= to generate a unique ID for each asm statement, useful for creating unique labels. The existing code translated this to $= which is not valid LLVM inline asm syntax.
This changes the translation to use ${:uid} which is the correct LLVM syntax for generating unique IDs.
🤖 Generated with Claude Code