Fix #4938 - Be stricter wrt. supported AddrExp in toConstElem() #4939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
commented
May 24, 2025
gen/toconstelem.cpp
Outdated
| @@ -401,7 +401,7 @@ class ToConstElemVisitor : public Visitor { | |||
| return; | |||
| } | |||
|
|
|||
| // address of indexExp | |||
| /* address of indexExp | |||
There was a problem hiding this comment.
[for now just checking whether we hit this case anywhere in the testsuite]
There was a problem hiding this comment.
Nope, these are apparently represented as SymOffExp:
shared int[3] arr;
auto e = &arr[1];
auto bla = &arr;
…stElem() DMD seems to support AddrExp of struct literals only...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMD seems to support AddrExp of struct literals only...