Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for manylinux armv7 wheels #559

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

nosracd
Copy link
Contributor

@nosracd nosracd commented Jan 13, 2025

Follow-up to #557. cibuildwheel recently added support for an Ubuntu-based manylinux image for armv7, so this PR bumps the version of cibuildwheel to enable building manylinux wheels for armv7. Because the image is Ubuntu-based, this PR also overrides the before-all command for that image to install the necessary dependencies via apt.

bump cibuildwheel to a version with the experimental armv7 support

this image is ubuntu-based, so use an apt command to install glib and java
@nosracd nosracd requested a review from ihilt January 13, 2025 18:01
@nosracd nosracd self-assigned this Jan 13, 2025
Copy link
Contributor

@ihilt ihilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just wanted to note that at least one of these armv7 wheels is built on ubuntu focal which we no longer "officially" test.

@nosracd
Copy link
Contributor Author

nosracd commented Jan 14, 2025

Just wanted to note that at least one of these armv7 wheels is built on ubuntu focal which we no longer "officially" test.

That's a good thing to note; it's true of the other images too though. The other manylinux wheels are built off of centOS 7, for example.

@nosracd nosracd merged commit 912d3c7 into lcm-proj:master Jan 14, 2025
54 checks passed
@nosracd nosracd deleted the bump/cibuildwheel branch January 14, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants