Templates • Refactor multiple-unit components with flow rate multiplier #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue3536_multipleUnits
…ssue3536_multipleUnits
|
@JayHuLBL This is ready for review. |
JayHuLBL
reviewed
Nov 7, 2023
JayHuLBL
reviewed
Nov 7, 2023
There was a problem hiding this comment.
@AntoineGautier The change looks good to me, except one comment about the moving class.
JayHuLBL
approved these changes
Nov 8, 2023
mwetter
requested changes
Nov 16, 2023
There was a problem hiding this comment.
@AntoineGautier : This is almost ready to merge. See also the change 025c74d in which I replaced an inequality block with a multiOr which I think is more straightforward than doing tests on real numbers (although, in this case, it all happens during an event iteration).
mwetter
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3536 and #3527.
This is ready for review.