Issue3063 District DHW

[dhblum]

This is for #3063. In particular, it:

• Implements component level domestic hot water models for two sources: 1) district heat exchanger and auxiliary electric heat and 2) water-to-water heat pump with storage tank.
• Implements component level domestic hot water models for fixture load(s) and thermostatic mixing valve.
• Adds a building load option using the Building Time Series load model and heat pump-based ETS model that includes the heat pump with storage tank DHW generation source. Led to creation of associated partial ETS class that is extended with the original DHW modeling approach in one model, and the new one in another.
• Various updates to model names and documentation.
• Commits unit test results.

Still todo:

• Review
• Update release notes
• Check openmodelica unit tests pass with 1.22 update
• Add optimica unit tests to exclusion list

[dhblum]

@mwetter I've updated the port locations and also the icons for the heat pump and heat pump with DHW subsystems. As far as I know, there's still the issue of simulating some models in Optimica. But let me know if there's anything else needed that you see to make this ready to merge.

[mwetter]

@dhblum : Please go ahead and merge it when the release notes are updated (which I think you did today).
Regarding your note about issues with some models in Optimica, I believe these are old issues, right? I am asking as I don't see a new entry in conf.yml

[dhblum]

Thanks @mwetter. Yes I added release notes today. I have not added the optimica errors to conf.yml yet. The openmodelica tests will also fail if the unit test image isn't updated to 1.22.0. I can either add to the conf.yml until #3603 is merged, or wait for #3603 to be merged before merging this one.

[mwetter]

@dhblum : I suggest you don't add the openmodelica entries in conf.yml. I hope to have fixed the latest timeouts in the PR of #3603. The PR should run this morning as there is only one more in the queue ahead.

[dhblum]

@mwetter Sounds good, I'll hold off until #3603 is merged.

[dhblum]

@mwetter Unit tests for openmodelica are failing still after merging the latest master with update to OM 1.22.0, with a failure of initialization for one model. But, when I run that model with OM 1.22.0 locally it works fine. The only difference I can see is that I run on Ubuntu 20 while the travis unit test runs with a Ubuntu 22 (Docker). Do you have experience that the same OM version but on different OS versions can cause a problem?

[mwetter]

Different OS and OS versions may yield slightly different results, such as due to different compiler versions and/or libraries. I suggest you put it on the exclude list for now, and when we update to the new OpenModelica version, revisit it.

[dhblum]

Ok I see, thanks. Sounds reasonable, I'll add it to the exclude list.

[dhblum]

@mwetter When you typically merge to master do you have any preference for squash merges or not?

[mwetter]

Either is fine.