Issue2885 fan coil unit controls #2946

karthikeyad-pnnl · 2022-03-31T16:02:29Z

@JayHuLBL : I am creating this PR for the fan coil unit controls. I have currently assigned the destination branch as the 'master' branch. Can you please create a new development branch "issue2885_FanCoilUnitControls" on lbl-srg/modelica-buildings? I will then edit the PR to use that as the target branch.

Merge lbl master into pnnl master

JayHuLBL · 2022-03-31T17:19:49Z

@karthikeyad-pnnl I just created the branch issue2885_FanCoilUnitControls for this PR. You can rebase the PR now.

karthikeyad-pnnl · 2022-03-31T18:27:19Z

@karthikeyad-pnnl I just created the branch issue2885_FanCoilUnitControls for this PR. You can rebase the PR now.

Thanks!

…time in mos file

…uildings:issue1913_g36_final

…nabled until the fan is proven ON

… all of them. Added svg file for control diagrams

karthikeyad-pnnl · 2022-11-30T23:26:31Z

@JayHuLBL: @terrancelu92 and I have updated the files according to the previous comments. Please see my responses in bold for each of the comments. Thanks!

@karthikeyad-pnnl Please merge the latest base branch to your branch.

See the comments below:

in FanCoilUnit.Subsequences.FanSpeed, rename the parameter heaSpeMin, heaSpeMax to heaSpe_min, heaSpe_max. The intention is to make the min/max parameter to have the surfix _min, _max.
Files changed accordingly.

in FanCoilUnit.Subsequences.FanSpeed, rename the group name Heating loop parameters to Heating loop. Also, you may combine the Deadband parameters and Transition parameters to Deadband. Change the comments of the heaDea to Heating loop signal limit above which it changes from deadband mode to heating mode.
Files changed accordingly.

in FanCoilUnit.Subsequences.FanSpeed, change the instance name isOcc to notUno.
Files changed accordingly.

in FanCoilUnit.Subsequences.FanSpeed, change the parameter name heaPerMin, heaPerMax to uHea_min, uHea_max, as well as the cooling loop parameters.
Files changed accorddingly.

in FanCoilUnit.Subsequences.FanSpeed, if fan is not proven on (uFanPro=false) and it is not in unoccupied operation mode, the fan speed will be one (yFanSpe=1)?
Updated fan speed logic so that fan speed is at minimum until it is proven on

in FanCoilUnit.Subsequences.PlantRequests, the parameters like chiWatResReqLim3, as we can directly use the value specified in the G36, such like chiWatResReqLim3, it is 5.56. In the info section, we can write it as 10 F (5.56 C).
Documentation updated accordingly

in FanCoilUnit.Subsequences.PlantRequests, it has the check if it is in cooling max or heating max mode. But it did not document in the info section. It seems not being specified in the G36?
The check is for fan at max cooling speed, which is specified in section 5.22.8.1.a in G36.

in FanCoilUnit.Subsequences.SupplyAirTemperature, rename the parameter heaPerMin to uHea_min.
Files changed accordingly

in FanCoilUnit.Subsequences.SupplyAirTemperature, rename THeaSupAirHi and TCooSupAirHi to THeaSup_max and TCooSup_min, rename TAirSupSet to TSupSet.
Files changed accordingly.

in FanCoilUnit.Subsequences.SupplyAirTemperature, in info section, add space Similarly,TAirSupSet
Files changed accordingly.

in FanCoilUnit.Subsequences.SupplyAirTemperature, rename the TZonSetHea to TZonHeaSet
Files changed accordingly.

in FanCoilUnit.Subsequences.SupplyAirTemperature, in the info section, the diagram plot, please make sure the parameter names are consistent with the names in the code. For example, in the plot, it has THeaSupAirHi, while in code, it is THeaSupAirMax.
Images and files changed accordingly.

in FanCoilUnit.Subsequences.SupplyAirTemperature, we used two PID controllers for heating and cooling coil. Is it possible to use one controller, but change the min, max value to [-1, 1] and then do conversion to positive value, depending on yHeaCoi, yCooCoi?
My thought process was to use the two separate PI controllers to provide separate tunable parameters for the heating and cooling coils, since the dynamics of the heating and cooling actions may be different. Are we using the method you proposed anywhere else in the Buildings library?

in FanCoilUnit.Subsequences.SupplyAirTemperature, in the info section, uCoo and uHea are set to zero when ..., should it be yHeaCoi and yCooCoi are set to zero when ...?
Documentation changed accordingly.

JayHuLBL · 2023-07-31T21:08:01Z

@karthikeyad-pnnl

In FanCoilUnit.Controller, the following connectors rename and the comments should be passed to the subsequences
- change the output connector yFan to y1Fan and change the comment to Fan command on status,
- change the output connector yFanSpe to yFan and change the comment to Fan command speed,
- change the input uFanPro to u1FanPro
- change uOcc to u1Occ, uFan to u1Fan, uWin to u1Win

Updated names and comments of connections in FanCoilUnit folder

Updated names of the connections in validation models

Propagated the naming changes to the validation scripts

Updated unit test logs

…al documentation to the plant requests subsequence validation

karthikeyad-pnnl · 2023-10-17T00:32:03Z

@JayHuLBL We have updated the interface instances according to the above comments. Please review the changes when you get a chance. Thanks!

JayHuLBL · 2023-11-29T19:05:49Z

Buildings/Controls/OBC/ASHRAE/FanCoilUnit/Subsequences/SupplyAirTemperature.mo

+  "Subsequence for calculating supply air temperature setpoint"
+
+  parameter Boolean have_cooCoi
+    "Does the fan coil unit have a cooling coil? True: Yes, False: No";


change the comment to True: the unit has a cooling coil, and give it a default value true

JayHuLBL · 2023-11-29T19:06:07Z

Buildings/Controls/OBC/ASHRAE/FanCoilUnit/Subsequences/SupplyAirTemperature.mo

+    "Does the fan coil unit have a cooling coil? True: Yes, False: No";
+
+  parameter Boolean have_heaCoi
+    "Does the fan coil unit have a heating coil? True: Yes, False: No";


True: the unit has a heating coil

JayHuLBL · 2023-11-29T19:13:25Z

Buildings/Controls/OBC/ASHRAE/FanCoilUnit/Subsequences/SupplyAirTemperature.mo

+
+  Buildings.Controls.OBC.CDL.Interfaces.RealOutput yCooCoi(
+    final unit="1",
+    displayUnit="1") if have_cooCoi


The yCooCoi and yHeaCoi are conditional connectors. However, the conditions are not propagated upstream. For example, the instances mul3, swiCooCoi, cooPIDCoo can be conditional removed if have_cooCoi=false. so that the parameters needed in instance cooPIDCoo can be disabled.

The conditions to diable parameters may need to be propagated to Buildings.Controls.OBC.ASHRAE.FanCoilUnit.Controller.

JayHuLBL · 2023-11-29T19:14:22Z

Buildings/Controls/OBC/ASHRAE/FanCoilUnit/Subsequences/SupplyAirTemperature.mo

+equation
+  connect(uHea, linTHeaSupAir.u) annotation (Line(points={{-140,40},{-74,40},{-74,
+          60},{-62,60}}, color={0,0,127}));
+


remove the empty lines.

JayHuLBL · 2023-11-29T19:18:44Z

Buildings/Controls/OBC/ASHRAE/FanCoilUnit/Subsequences/FanSpeed.mo

+  "Fan speed setpoint subsequence"
+
+  parameter Boolean have_cooCoi
+    "Does the fan coil unit have a cooling coil? True: Yes, False: No";


update the comment and set the default value to true.

Also, please propagate the condition to instances and parameters.

JayHuLBL

@karthikeyad-pnnl Please see the inline comments. There are following html errors:

jianjunhu@ubuntu:~/GitFolder/karthikeyad-pnnl/modelica-buildings/Buildings$ ../bin/validateHTML.py 
The following malformed html syntax has been found:
[-- ./Controls/OBC/ASHRAE/FanCoilUnit/Subsequences/Validation/PlantRequests.mo ]
line 55 column 1 - Warning: inserting implicit <p>
line 25 column 1 - Warning: trimming empty <p>
line 55 column 1 - Warning: trimming empty <p>

karthikeyad-pnnl and others added 22 commits September 1, 2020 11:17

Merge pull request #20 from lbl-srg/master

a432926

Merge lbl master into pnnl master

Merge remote-tracking branch 'upstream/master'

3b2b6ca

Merge remote-tracking branch 'upstream/master'

7f9c083

Merge remote-tracking branch 'upstream_local/master'

b8b08fe

Merge branch 'lbl-srg:master' into master

53454bf

Merge branch 'lbl-srg:master' into master

45d798b

Merge branch 'lbl-srg:master' into master

ec99cc6

Merge branch 'lbl-srg:master' into master

b5ae2ff

Added packages for fan coil unit control sequences

0709671

Backing up files

2fd6809

Backing up files

d680a40

Updated formatting

0eb59d0

Added documentation sections and updated formatting

d14ded5

Updated documentation and validation model for main controller

f7aae21

Added control logic diagrams to information sections

9e1c512

Updated package.order files

aced90f

Added simulation settings to validation models

242f261

Fixed newlines at end of mos file

3636340

Adding unit test results for main FCU controller

b573ce1

Removed example icon file extension from Modelica Standard Library

60c97db

Added unit test results for subsequences

d344a80

Updated file spacing

ec27366

karthikeyad-pnnl changed the base branch from master to issue2885_FanCoilUnitControls March 31, 2022 18:06

karthikeyad-pnnl added 5 commits April 4, 2022 08:59

Updated stop time in validation model settings to correspond to stop …

477025d

…time in mos file

Updated models based on feedback during presentation

2732a20

Removed redubndant pre blocks

6d090a6

Added model for plant requests from G36 package on lbl-srg/modelica-b…

bd59301

…uildings:issue1913_g36_final

Added request generation block to fan coil unit controls package

aea0310

karthikeyad-pnnl added 8 commits November 28, 2022 04:35

Updated unit test results

7edd0e7

Changed annotation and comments for parameters

08b449f

Updated fan speed logic to switch to deadband speed once the fan is e…

285ab15

…nabled until the fan is proven ON

Updated unit test results

9c2cc04

Updated text in documentation sections

41aa8cb

Updated interface instance names

8273a1c

Updated unit test results

3212320

Updated documentation and images so that parameter names match across…

fdee3c4

… all of them. Added svg file for control diagrams

mwetter assigned JayHuLBL Mar 8, 2023

junkewang001 and others added 9 commits October 4, 2023 16:07

Updated names and comments of connections in FanCoilUnit folder

c40af7d

Merge pull request #96 from junkewang001/issue2885_FanCoilUnitControls

8b45252

Updated names and comments of connections in FanCoilUnit folder

Updated names of the connections in validation models

d6631b0

Merge pull request #100 from junkewang001/issue2885_FanCoilUnitControls

1d3ac0e

Updated names of the connections in validation models

Propagated the naming changes to the validation scripts

7470e82

Merge pull request #101 from junkewang001/issue2885_FanCoilUnitControls

f03e16c

Propagated the naming changes to the validation scripts

Updated unit test logs

0d0bb42

Merge pull request #102 from junkewang001/issue2885_FanCoilUnitControls

4cbc0f2

Updated unit test logs

Updated interface names in the documentation sections. Added addition…

982fdb9

…al documentation to the plant requests subsequence validation

JayHuLBL reviewed Nov 29, 2023

View reviewed changes

JayHuLBL requested changes Nov 29, 2023

View reviewed changes

JayHuLBL merged commit 16f5c4b into lbl-srg:issue2885_FanCoilUnitControls Jan 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue2885 fan coil unit controls #2946

Issue2885 fan coil unit controls #2946

karthikeyad-pnnl commented Mar 31, 2022

JayHuLBL commented Mar 31, 2022

karthikeyad-pnnl commented Mar 31, 2022

karthikeyad-pnnl commented Nov 30, 2022 •

edited

Loading

JayHuLBL commented Jul 31, 2023

karthikeyad-pnnl commented Oct 17, 2023

JayHuLBL Nov 29, 2023 •

edited

Loading

JayHuLBL Nov 29, 2023

JayHuLBL Nov 29, 2023

JayHuLBL Nov 29, 2023

JayHuLBL Nov 29, 2023

JayHuLBL left a comment

Issue2885 fan coil unit controls #2946

Issue2885 fan coil unit controls #2946

Conversation

karthikeyad-pnnl commented Mar 31, 2022

JayHuLBL commented Mar 31, 2022

karthikeyad-pnnl commented Mar 31, 2022

karthikeyad-pnnl commented Nov 30, 2022 • edited Loading

JayHuLBL commented Jul 31, 2023

karthikeyad-pnnl commented Oct 17, 2023

JayHuLBL Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

JayHuLBL Nov 29, 2023

Choose a reason for hiding this comment

JayHuLBL Nov 29, 2023

Choose a reason for hiding this comment

JayHuLBL Nov 29, 2023

Choose a reason for hiding this comment

JayHuLBL Nov 29, 2023

Choose a reason for hiding this comment

JayHuLBL left a comment

Choose a reason for hiding this comment

karthikeyad-pnnl commented Nov 30, 2022 •

edited

Loading

JayHuLBL Nov 29, 2023 •

edited

Loading