Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2180 main boiler plant controller #2685

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2193 commits
Select commit Hold shift + click to select a range
c723d2d
Included the fixes learned from the case study, #2293 [ci skip]
JayHuLBL May 13, 2021
5a0a85c
Corrected boundary condition and initial conditions for #2488 (#2489)
mwetter May 14, 2021
b9e3fc3
Issue2491 spawn documentation (#2494)
mwetter May 14, 2021
715a03e
updated reference results #2293 [ci skip]
JayHuLBL May 14, 2021
e52b459
deleted U+FEFF symbol #2293 [ci skip]
JayHuLBL May 14, 2021
97600b1
Added missing space in message. (#2495)
mwetter May 18, 2021
c375e66
updated comments, #2293 [ci skip]
JayHuLBL May 18, 2021
328a93b
updated documents, #2293 [ci skip]
JayHuLBL May 19, 2021
dbfe293
Merge branch 'master' into issue2293_chiller_plant_seq
JayHuLBL May 19, 2021
bc425ed
updated references and comments, #2293 [ci skip]
JayHuLBL May 19, 2021
952570c
updated reference after correcting PID control action, #2293 [ci skip]
JayHuLBL May 19, 2021
a37b392
Changed solver to Radau (#2496)
mwetter May 20, 2021
11b3a98
Corrected conversion script (#2497)
mwetter May 20, 2021
47423cd
Merge branch 'master' into issue2293_chiller_plant_seq
JayHuLBL May 20, 2021
bb216fa
merged top level controller, #2293 [ci skip]
JayHuLBL May 20, 2021
aa8a41a
Corrected keywords, #2293 [ci skip]
JayHuLBL May 20, 2021
3b6d02a
Issue2498 dymola 2022 (#2499)
mwetter May 23, 2021
34b4bb9
fix enthalpy typo (#2502)
carlesRT May 24, 2021
b8b11b1
Issue2498 dymola 2022 (#2500)
mwetter May 24, 2021
1396b9d
Merge branch 'master' into issue2293_chiller_plant_seq
JayHuLBL May 25, 2021
3388139
Issue2505 spawn spaces (#2507)
mwetter May 26, 2021
97b0879
Issue2492 spawn infiltration (#2511)
mwetter May 27, 2021
e7928f4
Corrected publication year (#2508)
mwetter May 27, 2021
58a02ee
Include 7.0.1 release notes for 8.0.0 release (#2516)
mwetter May 27, 2021
2499858
Merge branch 'master' into issue2293_chiller_plant_seq
JayHuLBL May 28, 2021
d061a3c
Issue2517 spawn error message (#2518)
mwetter May 28, 2021
b51613b
Add Spawn examples that only read one output variable but have no the…
mwetter May 29, 2021
6ac26ca
Update issue templates
mwetter Jun 3, 2021
8625263
Update issue templates (#2522)
mwetter Jun 3, 2021
3caf1f1
Update issue templates
mwetter Jun 3, 2021
87a3ebf
Patch release date (#2524)
mwetter Jun 4, 2021
c4c4daf
Ibpsa sync (#2525)
mwetter Jun 4, 2021
5fa0bed
Update binaries that prevent Spawn from hanging during errors (#2527)
mwetter Jun 7, 2021
3b2b6ca
Merge remote-tracking branch 'upstream/master'
karthikeyad-pnnl Jun 7, 2021
5a51b79
corrected up and down process selection, #2293 [ci skip]
JayHuLBL Jun 8, 2021
36963ee
Merge branch 'master' into issue2293_chiller_plant_seq
JayHuLBL Jun 8, 2021
6294eec
Update release notes and version for future development (#2529)
mwetter Jun 9, 2021
603385d
Remove unneeded experiment and change start value (#2533)
AntoineGautier Jun 14, 2021
c20cef0
Removed duplicate declaration of VABp_flow (#2535)
mwetter Jun 14, 2021
8489367
Merge Medium.Steam from IBPSA, branch issue1389_mediaSteam (#2536)
mwetter Jun 17, 2021
d2b49d1
Improved diagnostics message for Spawn. (#2538)
mwetter Jun 17, 2021
b78b7c0
Removed Python2.7 interface for #2540 (#2541)
mwetter Jun 23, 2021
de05799
Updated model and solver settings for #2542 (#2543)
mwetter Jun 23, 2021
3f4a4af
Deleted old reference results (#2547)
mwetter Jun 24, 2021
dd3df91
Corrected annotation for #2550 (#2551)
mwetter Jun 24, 2021
4df6925
updated connector names [ci skip]
JayHuLBL Jul 7, 2021
a59bd4c
refactored text [ci skip]
JayHuLBL Jul 7, 2021
c3a5475
Fixed undeclared parameters (#2558)
JayHuLBL Jul 12, 2021
073962b
Added missing extends statements for icons (#2563)
mwetter Jul 14, 2021
c180401
Corrected comment. (#2567)
mwetter Jul 14, 2021
b51be3c
adding conditional instances, [ci skip]
JayHuLBL Jul 14, 2021
914914e
added conditions to the connector, [ci skip]
JayHuLBL Jul 15, 2021
3e2ddc2
regroupding parameters, [ci skip]
JayHuLBL Jul 19, 2021
4867dd7
Replace cooling coil model (#2560)
AntoineGautier Jul 20, 2021
c47e9d3
Merge branch 'master' into issue2293_chiller_plant_seq
JayHuLBL Jul 22, 2021
70b31cd
Added test to avoid event at t=8.666180323908523E-06 in ASHRAE2006 (#…
mwetter Jul 26, 2021
5ed00f9
Fix DSP reset logic used in VAVReheat ASHRAE2006 model (#2559)
AntoineGautier Jul 26, 2021
049a90b
regrouping parameters [ci skip]
JayHuLBL Jul 26, 2021
c0f0df6
Slightly moved the connectors for weather data and HVAC for Spawn 5 z…
mwetter Jul 27, 2021
1635c0d
Removed include statement for IBPSA, #1507 (#2579)
mwetter Jul 27, 2021
b74862c
Renamed parameter in MultiAnd and MultiOr (#2581)
JayHuLBL Jul 28, 2021
680ea48
unified naming and comments
JayHuLBL Jul 29, 2021
5e49127
changed group names
JayHuLBL Jul 30, 2021
3abaf02
5GDHC ETS with optional WSE (#2566)
AntoineGautier Aug 9, 2021
912b285
Merge new filter implementation for actuators (#2539)
mwetter Aug 10, 2021
c7576a3
Set start value for frame to avoid warning (#2587)
mwetter Aug 13, 2021
294b2ea
Ibpsa sync issue1513_pressureIndependent (#2586)
mwetter Aug 13, 2021
4db2a2e
Made BaseProperties replaceable in Media.Air (#2589)
mwetter Aug 16, 2021
074b135
Refactored implementation to properly handle start time unequal to 0 …
mwetter Aug 17, 2021
9e56166
DHC Buried Pipes (#2409)
bravache Aug 18, 2021
2452b93
Issue2544 ZoneGroup (#2557)
bravache Aug 18, 2021
7c35158
fixed typo [ci skip]
JayHuLBL Aug 23, 2021
b9b4b74
updated pressure check for failsafe sequence, added pre block to brea…
JayHuLBL Aug 26, 2021
4ddb82d
Issue2594 add hydraulic configurations to coil (#2595)
mwetter Aug 30, 2021
03be483
Generic cooling plant (#2531)
AntoineGautier Aug 31, 2021
772e66d
updated reference results, [ci skip]
JayHuLBL Aug 31, 2021
23f2ddd
merged master [ci skip]
JayHuLBL Aug 31, 2021
6a37f73
updated class after merging master [ci skip]
JayHuLBL Sep 1, 2021
037d285
corrected html malform
JayHuLBL Sep 1, 2021
2737aaa
corrected process sequence [ci skip]
JayHuLBL Sep 3, 2021
c84943a
created script for top lvel controller validation model
JayHuLBL Sep 3, 2021
d89d0ea
removed fixme, added parameter attributes
JayHuLBL Sep 3, 2021
2930b84
removed UTF-8 BOM
JayHuLBL Sep 3, 2021
558ac77
Updated documentation for #2600 (#2601)
mwetter Sep 4, 2021
4b7828f
Issue2596 radiant controllers (#2604)
mwetter Sep 8, 2021
714889c
Removed setuptools from pip3 (#2605)
mwetter Sep 8, 2021
bbee276
Added link to Spawn user guide in getting started (#2603)
mwetter Sep 8, 2021
652632b
Updated release notes with changes introduced in 8.0.1 (#2609)
mwetter Sep 9, 2021
666d3a2
removed single quote, #2612 (#2613)
JayHuLBL Sep 14, 2021
89bf740
Merged IBPSA, branch issue1494_plugflowpipe_singleoutlet (#2611)
mwetter Sep 15, 2021
7f9c083
Merge remote-tracking branch 'upstream/master'
karthikeyad-pnnl Sep 15, 2021
f76c2d8
Merge new weather data implementation from IBPSA (#2616)
mwetter Sep 19, 2021
66dad97
Patched conversion file to correct library name (#2615)
mwetter Sep 19, 2021
31e5f9a
Added changes to connector location and documentation (#2621)
mwetter Sep 20, 2021
2378ff8
Correct links in revision notes (#2623)
mwetter Sep 20, 2021
40c6f8d
Remove parameter prefix (#2632)
mwetter Sep 21, 2021
806aa91
Included ModelicaUtilities head (#2633)
JayHuLBL Sep 21, 2021
7006830
Updated controls (#2637)
mwetter Sep 22, 2021
0941986
Issue2624 space cooling tutorial (#2625)
dhblum Sep 22, 2021
733a8f4
Ibpsa sync (#2638)
mwetter Sep 22, 2021
6b6c151
Updated documentation for #2641 (#2642)
mwetter Sep 23, 2021
d78addc
Corrected if expressions (#2643)
JayHuLBL Sep 27, 2021
d94809c
Updated OpenModelica version (#2649)
mwetter Oct 1, 2021
4a6285f
Make cryptographic hash functions static (#2646)
kbenne Oct 2, 2021
b65beff
Rename CDL.*Switch blocks (#2654)
JayHuLBL Oct 5, 2021
b8b08fe
Merge remote-tracking branch 'upstream_local/master'
karthikeyad-pnnl Oct 6, 2021
92c9a2c
Merge remote-tracking branch 'upstream/issue2293_chiller_plant_seq' i…
karthikeyad-pnnl Oct 6, 2021
41f40ac
Committing first implementation of BoilerPlantEnabler and unit test f…
karthikeyad-pnnl May 4, 2020
e1301f6
Updated files based on feedback received from Milica
karthikeyad-pnnl May 8, 2020
f35ab51
Removed old image for information section
karthikeyad-pnnl May 8, 2020
b07420f
Removed unit test files for previous file-name.
karthikeyad-pnnl May 8, 2020
e2216eb
Adding file generated by unit test
karthikeyad-pnnl May 8, 2020
6039e26
Updated validation file to remove invalid keyword argument detected b…
karthikeyad-pnnl May 10, 2020
b3e6f3e
Updated parameter name in information section
karthikeyad-pnnl May 12, 2020
3574158
Files updated according to comments received on 05/15/20.
karthikeyad-pnnl May 15, 2020
dc41954
Updated code formatting.
karthikeyad-pnnl May 15, 2020
3158668
Updated formatting
karthikeyad-pnnl May 18, 2020
09eb1b1
Updated files to implement improved contol process.
karthikeyad-pnnl May 16, 2020
77b4ff6
Updated formatting
karthikeyad-pnnl May 18, 2020
d6964d0
Latest unit test files
karthikeyad-pnnl May 18, 2020
628fc07
Latest unit test run results
karthikeyad-pnnl May 20, 2020
af2393d
Corrected model to resolve issues with incorrect sequence implementat…
karthikeyad-pnnl May 24, 2020
b74cd27
Updated unit test results for correct implementation
karthikeyad-pnnl May 24, 2020
c874665
Reverted PlantEnable to previous approved version
karthikeyad-pnnl May 29, 2020
122df29
Updated validation scripts and plots.
karthikeyad-pnnl May 29, 2020
6153877
Updated formatting
karthikeyad-pnnl May 29, 2020
009f7e9
Unit test results
karthikeyad-pnnl May 29, 2020
1a0d406
updated mat file name in the mos script, generated package order usin…
milicag Jun 1, 2020
b5b3198
changed model to block, formatted code
milicag Jun 1, 2020
7101835
removed empty space, #1925 [ci skip]
JayHuLBL Jun 2, 2020
3b88768
updated models
milicag Aug 31, 2020
5e00479
test for boiler plant pass locally
milicag Aug 31, 2020
346b344
Moved main controller from issue2142
karthikeyad-pnnl Oct 14, 2020
0db1768
Updated names for Boolean flags
karthikeyad-pnnl Oct 15, 2020
d8fa184
Resolved incorrect naming issues
karthikeyad-pnnl Oct 15, 2020
6ce80a8
Added closed-loop validation models
karthikeyad-pnnl Oct 20, 2020
7964c10
Removed unnecessary files
karthikeyad-pnnl Oct 21, 2020
b3943e7
Updated package order files
karthikeyad-pnnl Oct 21, 2020
1175599
Added check valves to plant model and added pump curves
karthikeyad-pnnl Oct 21, 2020
63b0e36
Resolved bugs in compilation
karthikeyad-pnnl Oct 21, 2020
987265a
Updated graphical layer layout
karthikeyad-pnnl Oct 23, 2020
e816631
Updated icon layer
karthikeyad-pnnl Oct 23, 2020
398195f
Updated unit delay sampling period
karthikeyad-pnnl Oct 23, 2020
a42c1f2
Added parameter to avoid division by zero
karthikeyad-pnnl Oct 23, 2020
346c68d
Updated closed-loop validation models
karthikeyad-pnnl Oct 23, 2020
da25592
Updated models to resolve bugs in closed-loop validation
karthikeyad-pnnl Oct 23, 2020
39a0740
Removed protected statement
karthikeyad-pnnl Oct 23, 2020
245b281
Updated closed-loop validation model
karthikeyad-pnnl Oct 25, 2020
66bb78d
Moved valve position sampling to valve closing subsequence
karthikeyad-pnnl Oct 26, 2020
466a6f6
Simplified calculations and updated formatting
karthikeyad-pnnl Oct 26, 2020
89c8a7f
Moved completion feedback signal from within up and down-process cont…
karthikeyad-pnnl Oct 26, 2020
cd9b5a1
Removed dependance of output signals on plant enable status
karthikeyad-pnnl Oct 26, 2020
39967d9
Updated simulation parameters
karthikeyad-pnnl Oct 26, 2020
2babb37
Added legacy boiler plant model with isolation valve at pump outlet
karthikeyad-pnnl Oct 26, 2020
9d6f14f
Simplified control process and removed excess pump change output signal
karthikeyad-pnnl Nov 2, 2020
58652a7
Changed all array inputs to scalar inputs and vectorized at NHL
karthikeyad-pnnl Nov 2, 2020
46481c6
Added logical operator to pump stage change start signal to prevent c…
karthikeyad-pnnl Nov 2, 2020
2145cda
Updated formatting to comply with library standards
karthikeyad-pnnl Nov 2, 2020
5048bb2
Fixed change process completion signal logic and information section
karthikeyad-pnnl Nov 4, 2020
a100a3c
Fixed lead pump enable logic for dedicated primary pumps and updated …
karthikeyad-pnnl Nov 4, 2020
38d3fef
Removed edge detector for plant enable signal
karthikeyad-pnnl Nov 4, 2020
ab19fa5
Updated parameter enable flags
karthikeyad-pnnl Nov 5, 2020
3f250f0
Formatted main controller model and validation model, fixed bugs and …
karthikeyad-pnnl Nov 5, 2020
f087851
.mos script for main controller validation model
karthikeyad-pnnl Nov 5, 2020
4ca21bc
Fixed bug
karthikeyad-pnnl Nov 6, 2020
b02fcb9
Updated icon
karthikeyad-pnnl Nov 6, 2020
43b7e87
Updated icon
karthikeyad-pnnl Nov 6, 2020
b81164e
Added And operator to input for down-process controller to ensure it …
karthikeyad-pnnl Nov 6, 2020
968c1bf
Changed calculation of hot water requests and added .mos file for sim…
karthikeyad-pnnl Nov 6, 2020
0c38625
Updated documentation and formatting
karthikeyad-pnnl Nov 9, 2020
9ea0f09
Updated result file names to avoid conflict during unit test
karthikeyad-pnnl Nov 9, 2020
92a494e
Updated and simplified validation model after making changes at main …
karthikeyad-pnnl Nov 11, 2020
c824b9e
Updated validation model and validation script after making changes a…
karthikeyad-pnnl Nov 11, 2020
fa325bc
Updated sequence to match changes made in development branch
karthikeyad-pnnl Nov 11, 2020
17c31d2
Updated validation model to resolve missing connections due to change…
karthikeyad-pnnl Nov 11, 2020
3cf0dad
Updated conditional enable statements to match boolean flag parameter…
karthikeyad-pnnl Nov 11, 2020
811cec5
Parametrised unit delay sampling period
karthikeyad-pnnl Nov 16, 2020
cef0f04
Updated validation model and script
karthikeyad-pnnl Nov 16, 2020
8085f6a
Updated validation model
karthikeyad-pnnl Nov 16, 2020
c2da761
Added unit delay sampling period value to all minimum flow setpoint b…
karthikeyad-pnnl Nov 16, 2020
6081332
Added/edited legacy closed loop test files
karthikeyad-pnnl Nov 24, 2020
f52b3db
Checked out reference results from issue2142 branch
karthikeyad-pnnl Nov 11, 2020
d0afe4e
Added unit test results
karthikeyad-pnnl Nov 16, 2020
64c008b
Updated parameters
karthikeyad-pnnl Nov 24, 2020
4f69e23
Merge branch 'issue2180_partial' of https://github.com/karthikeyad-pn…
karthikeyad-pnnl Oct 6, 2021
a8b435c
Added funnel_comp to directories to be deleted (#2657)
mwetter Oct 6, 2021
7e2e5f2
Issue2652 Refactor VAVReheat and its base classes (#2656)
mwetter Oct 6, 2021
d2ce0a9
Resolved issues caused by CDL updates
karthikeyad-pnnl Dec 16, 2020
bedc3a5
Updated models to resolve errors due to updated CDL library
karthikeyad-pnnl Jan 6, 2021
778ea50
Updated example files
karthikeyad-pnnl Jan 6, 2021
553c958
Replaced pump speed signal vector with scalar output since speed sign…
karthikeyad-pnnl Jan 26, 2021
d7560cd
Changed logic to detect change in pump status
karthikeyad-pnnl Jan 27, 2021
fa34eb5
Added inputs for obtaining status of components from plant
karthikeyad-pnnl Jan 28, 2021
36ee067
Made updates to add measured component status for boiler plant
karthikeyad-pnnl Mar 3, 2021
17fe9a3
Added output for boiler supply temperature setpoint
karthikeyad-pnnl Mar 4, 2021
2b7afd6
Changed logic for pump speed when pumps are turned on
karthikeyad-pnnl Mar 4, 2021
e3876ce
Added logic to wait for pumps to be proven on before completing pump …
karthikeyad-pnnl Mar 4, 2021
255db55
Changed pump speed signal output to scalar
karthikeyad-pnnl Mar 4, 2021
f7beb87
Updated logic to check for boiler status proven on before signaling p…
karthikeyad-pnnl Mar 4, 2021
4ab4684
Changed validation model to include true-delay for mimicking proving …
karthikeyad-pnnl Mar 4, 2021
f4f62cd
Updated closed-loop validation models
karthikeyad-pnnl Mar 4, 2021
57b06b5
Added models for equipment rotation sequences
karthikeyad-pnnl Mar 4, 2021
62ffe48
Updated formatting and removed redundant files
karthikeyad-pnnl Apr 9, 2021
c4bebf4
Updated formatting
karthikeyad-pnnl Apr 12, 2021
eae3369
Added new block for equipment rotation module
karthikeyad-pnnl Apr 12, 2021
27c5aa7
Updated package order
karthikeyad-pnnl Apr 12, 2021
4b4ec7b
Updated parameters
karthikeyad-pnnl Apr 12, 2021
2893a79
Added script for boiler rotation sequence validation files
karthikeyad-pnnl Apr 12, 2021
da25f76
Updated script for plant disable
karthikeyad-pnnl Apr 12, 2021
315dbf8
Modified subsequence
karthikeyad-pnnl Apr 13, 2021
bec0140
Fixed bugs to resolve improper operation of equipment rotation contro…
karthikeyad-pnnl Apr 13, 2021
c306c69
Added unit test results for equipment rotation sequences
karthikeyad-pnnl Apr 13, 2021
6d2d99e
Fixed leftover merge conflicts in files
karthikeyad-pnnl Oct 7, 2021
d51b5c8
Updated references to latest CDL package
karthikeyad-pnnl Oct 7, 2021
3173bca
Updated model to resolve translation issues
karthikeyad-pnnl Oct 7, 2021
c56306f
Merged IBPSA, issue1494_plugflowpipe_singleoutlet (#2659)
mwetter Oct 7, 2021
17f34c4
Removed wrong experiment annotation in partial model (#2661)
mwetter Oct 7, 2021
df01f53
Maded idf and weather file name public (#2664)
mwetter Oct 7, 2021
cf88221
Changed parameter declarations for case study (#2666)
mwetter Oct 8, 2021
5f96d45
Updated splitter pressure drop values to resolve issues as found duri…
karthikeyad-pnnl Oct 8, 2021
aa6c335
Updated models with parameters
karthikeyad-pnnl Oct 12, 2021
0ffae5d
Updated parameters to match sizing used in boiler plant case study. A…
karthikeyad-pnnl Oct 13, 2021
387df2f
Merge changes to user guide of mover package (#2665)
mwetter Oct 13, 2021
b6eabde
Updated parameter enable conditions. Updated comments on blocks. Fixe…
karthikeyad-pnnl Oct 13, 2021
c1aae7b
Updated models to resolve numerical errors. Added data file for time-…
karthikeyad-pnnl Oct 13, 2021
6af871c
Added automation script for validation model. Updated formatting
karthikeyad-pnnl Oct 14, 2021
19eb304
Updated documentation. Added boiler plant schematics
karthikeyad-pnnl Oct 14, 2021
5a7a617
Corrected capitalization of leftJustified (#2676)
mwetter Oct 14, 2021
85dbc3e
Added missing parameter declaration (master) (#2671)
mwetter Oct 14, 2021
b138e76
Updated package order files and removed redundant pump curves
karthikeyad-pnnl Oct 14, 2021
c25b3ca
Updated icon layer of primary pump controller
karthikeyad-pnnl Oct 15, 2021
4add1cf
Updated logic to fix issue with lag pump enable detected in validatio…
karthikeyad-pnnl Oct 15, 2021
e1c1d89
Updated validation models for primary and secondary pump controllers
karthikeyad-pnnl Oct 15, 2021
a52d478
Updated validation model for staging up process
karthikeyad-pnnl Oct 15, 2021
067465e
Updated validation model scripts to use right variable for pump speed
karthikeyad-pnnl Oct 15, 2021
77e0820
Updated unit test results
karthikeyad-pnnl Oct 15, 2021
879852a
Created common class for sequence enabling lag pump using flowrate in…
karthikeyad-pnnl Oct 15, 2021
5762ef1
Updated unit test results for main controller
karthikeyad-pnnl Oct 15, 2021
5d91d27
Updated validation model scripts
karthikeyad-pnnl Oct 15, 2021
8d28d89
Added tolerance to validation model
karthikeyad-pnnl Oct 15, 2021
5e8c165
Added unit test results to boiler plant example package
karthikeyad-pnnl Oct 15, 2021
1d58c60
Updated comments and documentation on equipment rotation subsequences
karthikeyad-pnnl Oct 15, 2021
0da60a6
Updated reference results with latest set of good results from issue2…
karthikeyad-pnnl Oct 15, 2021
58de9e0
Removed redundant parameters
karthikeyad-pnnl Oct 15, 2021
c779fa7
Merged IBPSA, issue1531_der_spliceFunction (#2681)
mwetter Oct 16, 2021
3ee0f00
Ibpsa sync (#2686)
mwetter Oct 18, 2021
3ebb153
Issue2689 cdl icons (#2690)
mwetter Oct 22, 2021
b40792a
merged master [ci skip]
JayHuLBL Oct 25, 2021
c1c6e68
Merge pull request #32 from lbl-srg/master
karthikeyad-pnnl Oct 25, 2021
8e58d79
Merge pull request #33 from lbl-srg/issue2293_chiller_plant_seq
karthikeyad-pnnl Oct 25, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
11 changes: 11 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
libModelicaBuildingsEnergyPlus*.* filter=lfs diff=lfs merge=lfs -text
ModelicaBuildingsEnergyPlus*.dll filter=lfs diff=lfs merge=lfs -text
ModelicaBuildingsEnergyPlus*.lib filter=lfs diff=lfs merge=lfs -text
libepfmi*.* filter=lfs diff=lfs merge=lfs -text
libfmilib*.* filter=lfs diff=lfs merge=lfs -text
fmilib_shared*.* filter=lfs diff=lfs merge=lfs -text
epfmi*.* filter=lfs diff=lfs merge=lfs -text
VCRUNTIME*.dll filter=lfs diff=lfs merge=lfs -text
Buildings/Resources/src/ThermalZones/EnergyPlus/FMUs/Zones1.fmu filter=lfs diff=lfs merge=lfs -text
Buildings/Resources/src/ThermalZones/EnergyPlus/FMUs/Zones3.fmu filter=lfs diff=lfs merge=lfs -text
Buildings/Resources/bin/spawn-*/bin/spawn filter=lfs diff=lfs merge=lfs -text
31 changes: 31 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Open model '...'
2. Run script '....'
3. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Version**
- Modelica Buildings Library: [version or commit]
- Modelica simulation environment
- Operating system

**Additional context**
Add any other context about the problem here.
10 changes: 10 additions & 0 deletions .github/ISSUE_TEMPLATE/custom-issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
name: Custom issue
about: Issues other than bug report or feature request
title: ''
labels: ''
assignees: ''

---


20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.
98 changes: 98 additions & 0 deletions .github/workflows/formatting.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
# Workflow for CI tests
name: CI-documentation-and-format

# Controls when the action will run.
on:
# Triggers the workflow on push or pull request events but only for the master branch
push:
branches: [ master, maint_*, release* ]
pull_request:
branches: [ master, maint_*, release* ]

# Allows you to run this workflow manually from the Actions tab
# workflow_dispatch:

defaults:
run:
shell: bash
working-directory: Buildings

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:

test-formatting:
# Skip if the commit message contains "ci skip"
if: "!contains(github.event.head_commit.message, 'ci skip')"

runs-on: ubuntu-18.04

steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v2

- uses: actions/setup-python@v2
with:
python-version: '3.6' # Version range or exact version of a Python version to use, using SemVer's version range syntax
architecture: 'x64' # optional x64 or x86. Defaults to x64 if not specified

- name: "Install pip"
run: pip3 install --upgrade pip wheel

- name: "Install sphinx and its dependencies"
run: pip3 install \
sphinx==2.1.2 \
sphinx-bootstrap-theme==0.7.1 \
sphinxcontrib-bibtex==0.4.2 \
sphinxcontrib-plantuml==0.17 \
alabaster==0.7.12 \
MarkupSafe==1.1.1 \
Pygments==2.4.2 \
snowballstemmer==1.9.0 \
docutils==0.15.2 \
Babel==2.7.0 \
requests==2.22.0 \
Jinja2==2.10.1 \
latexcodec==1.0.7 \
pybtex==0.22.2 \
pybtex-docutils==0.2.1 \
oset==0.1.3 \
PyYAML==5.1.2

- name: "Install BuildingsPy"
run: pip3 install git+https://github.com/lbl-srg/BuildingsPy@master

- name: "Test html syntax"
run : ../bin/runUnitTests.py --validate-html-only

- name: "Test experiment setup"
run : ../bin/runUnitTests.py --validate-experiment-setup

- name: "Test if package.order are correct"
run : |
python -c 'import buildingspy.development.refactor as r; r.write_package_order(".", recursive=True)'
git diff --exit-code .

- name: "Verify files for invalid strings"
run: ${GITHUB_WORKSPACE}/bin/verifyFiles.py

- name: "Verify that all OpenModelica scripts are up to date, and no old scripts exist"
run : |
rm Resources/Scripts/OpenModelica/compareVars/*.mos
python -c 'import buildingspy.development.regressiontest as u; u.Tester().writeOpenModelicaResultDictionary()'
git status --porcelain Resources/Scripts/OpenModelica
test -z "$(git status --porcelain Resources/Scripts/OpenModelica)"

- name: "Test user guide"
run : (cd Resources/Documentation/userGuide; make regressiontest)

- name: "Test heat pump documentation"
run : (cd Resources/src/fluid/heatpumps/calibration/doc; make regressiontest)

- name: "Check for UnitConversion package to be consistent with the script that generates it"
run : |
cd ..
python Buildings/Resources/src/Controls/OBC/UnitConversions/unit_converters.py
git diff --exit-code Buildings

- name: Check for UTF-8 BOM
run: "! find . -name '*.mo' -print0 | xargs -0 grep -l $'^\\xEF\\xBB\\xBF' | grep ."
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ funnel_comp
# CMake build directory
######################################
/build
Buildings/Resources/src/fmi-library/build


# Temporary files generated by emacs
Expand Down Expand Up @@ -69,3 +70,6 @@ Buildings/Resources/src/fluid/heatpumps/calibration/doc/build/doctrees
# Spawn temporary directories
#########################################
tmp-eplus-*
eplus*
sqlite*
*/EnergyPlus-simulation*
105 changes: 72 additions & 33 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
os: Linux
dist: bionic

language: python

python:
- "3.6"

branches:
only:
- master
- /^maint_.*$/
- release

cache: pip

notifications:
Expand All @@ -19,38 +26,86 @@ services:

env:
global:
- ENERGYPLUS_VERSION=EnergyPlus-9.3.0-baff08990c-Linux-x86_64
- ENERGYPLUS_VERSION=EnergyPlus-9.5.0-de239b2e5f-Linux-Ubuntu18.04-x86_64
- MODELICA_JSON_VERSION=6d950c3592fa021aa914ba4ff34a67cbb69962c6
- MODELICA_JSON_HOME=${TRAVIS_BUILD_DIR}/modelica-json

jobs:
- TEST_ARG="make test-documentation test-experiment-setup test-autogenerated-files test-verify-files"
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.Controls.OBC\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.Controls.OBC\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.Controls.OBC\""
- TEST_ARG="make test-cdl-conformance"
- TEST_ARG="make test-energyplus-validations"
- TEST_ARG="make test-bestest test-spawn-portability"
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.{Air,Examples}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.{Air,Examples}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.{Air,Examples}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.ThermalZones.EnergyPlus\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.ThermalZones.EnergyPlus\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.ThermalZones.EnergyPlus\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.ThermalZones.Detailed.{BaseClasses,Constructions,Examples}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.ThermalZones.Detailed.{BaseClasses,Constructions,Examples}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.ThermalZones.Detailed.{BaseClasses,Constructions,Examples}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.ThermalZones.Detailed.Validation.BESTEST\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.ThermalZones.Detailed.Validation.BESTEST\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.ThermalZones.Detailed.Validation.BESTEST\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.ThermalZones.Detailed.Validation.{Initialization,LBNL_71T,TestConditionalConstructions}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.ThermalZones.Detailed.Validation.{Initialization,LBNL_71T,TestConditionalConstructions}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.ThermalZones.Detailed.Validation.{Initialization,LBNL_71T,TestConditionalConstructions}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.ThermalZones.Detailed.FLEXLAB\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.ThermalZones.Detailed.FLEXLAB\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.ThermalZones.Detailed.FLEXLAB\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.ThermalZones.ReducedOrder\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.ThermalZones.ReducedOrder\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.ThermalZones.ReducedOrder\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.{Applications,Experimental}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.{Applications,Experimental}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.{Applications,Experimental}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.Fluid.{Actuators,BaseClasses,Boilers,Chillers,CHPs,Delays}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.Fluid.{Actuators,BaseClasses,Boilers,Chillers,CHPs,Delays}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.Fluid.{Actuators,BaseClasses,Boilers,Chillers,CHPs,Delays}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.Fluid.{Examples,FMI,FixedResistances,Geothermal}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.Fluid.{Examples,FMI,FixedResistances,Geothermal}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.Fluid.{Examples,FMI,FixedResistances,Geothermal}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.Fluid.{HeatExchangers,HeatPumps,Interfaces}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.Fluid.{HeatExchangers,HeatPumps,Interfaces}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.Fluid.{HeatExchangers,HeatPumps,Interfaces}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.Fluid.{MassExchangers,MixingVolumes,Movers,Sensors,SolarCollectors,Sources,Storage,Utilities}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.Fluid.{MassExchangers,MixingVolumes,Movers,Sensors,SolarCollectors,Sources,Storage,Utilities}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.Fluid.{MassExchangers,MixingVolumes,Movers,Sensors,SolarCollectors,Sources,Storage,Utilities}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.Electrical\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.Electrical\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.Electrical\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.{Airflow,BoundaryConditions,Controls}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.{Airflow,BoundaryConditions,Controls}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.{Airflow,BoundaryConditions,Controls}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.HeatTransfer\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.HeatTransfer\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.HeatTransfer\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.{Obsolete.Controls,Occupants,Media}\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.{Obsolete.Controls,Occupants,Media}\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.{Obsolete.Controls,Occupants,Media}\""
- TEST_ARG="make test-dymola PACKAGE=\"Buildings.Utilities\""
- TEST_ARG="make test-optimica PACKAGE=\"Buildings.Utilities\""
- TEST_ARG="make test-jmodelica PACKAGE=\"Buildings.Utilities\""
- TEST_ARG="make test-omc"

before_install:
- sudo apt-get -y install python3.6-minimal # Provides /usr/bin/python3.6m
- echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
- if [[ "$TEST_ARG" == *test-dymola* ]]; then
docker pull "$DOCKER_USERNAME"/travis_ubuntu-1804_dymola:2021-x86_64;
- if [[ "$TEST_ARG" == *test-dymola* || "$TEST_ARG" == *test-bestest* || "$TEST_ARG" == *spawn-portability* ]]; then
docker pull "$DOCKER_USERNAME"/travis_ubuntu-1804_dymola:2022-x86_64;
cp Buildings/Resources/Scripts/travis/dymola/dymola $HOME/bin/;
fi;
- if [[ "$TEST_ARG" == *test-optimica* ]]; then
docker pull "$DOCKER_USERNAME"/travis-ubuntu-1804-optimica;
docker pull "$DOCKER_USERNAME"/travis-ubuntu-1804-optimica:r19089;
cp Buildings/Resources/Scripts/travis/optimica/jm_ipython.sh $HOME/bin/jm_ipython.sh;
fi;
- if [[ "$TEST_ARG" == *test-jmodelica* ]]; then
docker pull "$DOCKER_USERNAME"/ubuntu-1804_jmodelica_trunk;
cp Buildings/Resources/Scripts/travis/jmodelica/jm_ipython.sh $HOME/bin/jm_ipython.sh;
fi;
- if [[ "$TEST_ARG" == *test-energyplus* ]]; then
wget --no-verbose https://github.com/NREL/EnergyPlus/releases/download/v9.3.0/${ENERGYPLUS_VERSION}.tar.gz;
wget --no-verbose https://github.com/NREL/EnergyPlus/releases/download/v9.5.0/${ENERGYPLUS_VERSION}.tar.gz;
tar xzf ${ENERGYPLUS_VERSION}.tar.gz;
rm ${ENERGYPLUS_VERSION}.tar.gz;
mv -v ${ENERGYPLUS_VERSION}/energyplus ${ENERGYPLUS_VERSION}/EnergyPlus;
file ${ENERGYPLUS_VERSION}/EnergyPlus
ls -l ${ENERGYPLUS_VERSION}
echo "Installed EnergyPlus in ${PWD}/${ENERGYPLUS_VERSION}";
fi;
- if [[ "$TEST_ARG" == *test-cdl-conformance* ]]; then
Expand All @@ -64,38 +119,22 @@ before_install:
cd -;
echo "Installed modelica-json in ${MODELICA_JSON_HOME}";
fi;
- if [[ "$TEST_ARG" == *test-omc* ]]; then
docker pull "$DOCKER_USERNAME"/ubuntu-2004-omc:1.18.0;
fi;

# Install dependencies
# For sphinx, we need to install specific package versions, otherwise
# the html output may have small formatting differences which causes
# the test to fail
install:
- pip3 install --upgrade pip setuptools wheel
- pip3 install --upgrade pip wheel
- pip3 install --only-binary=numpy,scipy,matplotlib numpy==1.13.3 scipy==0.19.1 matplotlib==2.1.0
- if [[ "$TEST_ARG" == *test-documentation* ]]; then
pip3 install sphinx==2.1.2 \
sphinx-bootstrap-theme==0.7.1 \
sphinxcontrib-bibtex==0.4.2 \
sphinxcontrib-plantuml==0.17 \
alabaster==0.7.12 \
MarkupSafe==1.1.1 \
Pygments==2.4.2 \
snowballstemmer==1.9.0 \
docutils==0.15.2 \
Babel==2.7.0 \
requests==2.22.0 \
Jinja2==2.10.1 \
latexcodec==1.0.7 \
pybtex==0.22.2
pybtex-docutils==0.2.1 \
oset==0.1.3 \
PyYAML==5.1.2;
fi;
- pip3 install git+https://github.com/lbl-srg/BuildingsPy@master
- if [[ "$TEST_ARG" == *test-energyplus* ]]; then
export PATH=${PATH}:${TRAVIS_BUILD_DIR}/${ENERGYPLUS_VERSION};
pip3 install pandas==1.0.1;
fi;
- pip3 install git+https://github.com/lbl-srg/BuildingsPy@master

# Execute tests
script:
Expand Down
Loading