-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue2180 boiler plant main controller #2193
Issue2180 boiler plant main controller #2193
Conversation
Diagram(coordinateSystem(preserveAspectRatio=false,extent={{-120,-100},{120, | ||
100}})), | ||
__Dymola_Commands(file= | ||
"modelica://Buildings/Resources/Scripts/Dymola/Examples/Tutorial/Boiler/System6.mos" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a .mos script for the example model Buildings.Examples.BoilerPlant.ClosedLoopTest
.
@@ -0,0 +1,2251 @@ | |||
within Buildings.Controls.OBC.ASHRAE.PrimarySystem.BoilerPlant; | |||
model Controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model is still not working. It failed to check in Dymola.
@karthikeyad-pnnl I tried to run the model Are you working on some refactoring and should I wait to check the two models? |
@JayHuLBL : Hi Jianjun, I am not sure why the main controller isn't working. I am adding an open loop validation file for it today. I will also create an .mos file for closed-loop validation model. I will tag you once it's up. Thanks for checking out the issue! -Karthik |
@JayHuLBL : I have added an open-loop validation model for the main boiler plant controller. I have also added an mos file for the closed-loop test model. |
…into issue2204_gmt_mbl
Remove delay for load signal generation in examples and validations.
…ca-buildings into issue1951_5GDHC_ETS
…ca-buildings into issue1951_5GDHC_ETS [ci-skip]
…iable Reformulated model for lbl-srg#2221
…into issue2024_ASHRAE2006_sequence
…rocess completion
@milicag : Thanks, |
Closing this PR after creating new PR #2685 using fresh branch issue2180_MainBoilerPlantController. |
No description provided.