Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2180 boiler plant main controller #2193

Conversation

karthikeyad-pnnl
Copy link
Contributor

No description provided.

Diagram(coordinateSystem(preserveAspectRatio=false,extent={{-120,-100},{120,
100}})),
__Dymola_Commands(file=
"modelica://Buildings/Resources/Scripts/Dymola/Examples/Tutorial/Boiler/System6.mos"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a .mos script for the example model Buildings.Examples.BoilerPlant.ClosedLoopTest.

@@ -0,0 +1,2251 @@
within Buildings.Controls.OBC.ASHRAE.PrimarySystem.BoilerPlant;
model Controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model is still not working. It failed to check in Dymola.

@JayHuLBL
Copy link
Contributor

JayHuLBL commented Nov 5, 2020

@karthikeyad-pnnl I tried to run the model Buildings.Examples.BoilerPlant.ClosedLoopTest and Buildings.Examples.BoilerPlant.ClosedLoopTest_legacy with optimica but it failed. Then I realized that the the boiler plant main controller also failed to check in Dymola.

Are you working on some refactoring and should I wait to check the two models?

@karthikeyad-pnnl
Copy link
Contributor Author

@JayHuLBL : Hi Jianjun, I am not sure why the main controller isn't working. I am adding an open loop validation file for it today. I will also create an .mos file for closed-loop validation model. I will tag you once it's up. Thanks for checking out the issue!

-Karthik

@karthikeyad-pnnl
Copy link
Contributor Author

@JayHuLBL : I have added an open-loop validation model for the main boiler plant controller. I have also added an mos file for the closed-loop test model.

mwetter and others added 25 commits November 6, 2020 05:57
Remove delay for load signal generation in examples and validations.
@karthikeyad-pnnl
Copy link
Contributor Author

@milicag :
Hi Milica, this pull request is ready for review. It should contain all the boiler plant files. Please let me know if I should rebase it on a specific branch to remove any merge conflicts that may arise.

Thanks,
Karthik

@karthikeyad-pnnl
Copy link
Contributor Author

Closing this PR after creating new PR #2685 using fresh branch issue2180_MainBoilerPlantController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants