Removed default values in base class

lbl-srg · Jan 6, 2024 · e186be0 · e186be0
1 parent 1d88681
commit e186be0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/Buildings/Fluid/HeatExchangers/ThermalWheels/BaseClasses/Effectiveness.mo b/Buildings/Fluid/HeatExchangers/ThermalWheels/BaseClasses/Effectiveness.mo
@@ -2,21 +2,21 @@ within Buildings.Fluid.HeatExchangers.ThermalWheels.BaseClasses;
 model Effectiveness
   "Model for calculating the heat exchange effectiveness"
   extends Modelica.Blocks.Icons.Block;
-  parameter Modelica.Units.SI.Efficiency epsSenCoo_nominal(final max=1) = 0.8
+  parameter Modelica.Units.SI.Efficiency epsSenCoo_nominal(final max=1)
     "Nominal sensible heat exchanger effectiveness at the cooling mode";
-  parameter Modelica.Units.SI.Efficiency epsLatCoo_nominal(final max=1) = 0.8
+  parameter Modelica.Units.SI.Efficiency epsLatCoo_nominal(final max=1)
     "Nominal latent heat exchanger effectiveness at the cooling mode";
-  parameter Modelica.Units.SI.Efficiency epsSenCooPL(final max=1) = 0.75
+  parameter Modelica.Units.SI.Efficiency epsSenCooPL(final max=1)
     "Part load (75%) sensible heat exchanger effectiveness at the cooling mode";
-  parameter Modelica.Units.SI.Efficiency epsLatCooPL(final max=1) = 0.75
+  parameter Modelica.Units.SI.Efficiency epsLatCooPL(final max=1)
     "Part load (75%) latent heat exchanger effectiveness at the cooling mode";
-  parameter Modelica.Units.SI.Efficiency epsSenHea_nominal(final max=1) = 0.8
+  parameter Modelica.Units.SI.Efficiency epsSenHea_nominal(final max=1)
     "Nominal sensible heat exchanger effectiveness at the heating mode";
-  parameter Modelica.Units.SI.Efficiency epsLatHea_nominal(final max=1) = 0.8
+  parameter Modelica.Units.SI.Efficiency epsLatHea_nominal(final max=1)
     "Nominal latent heat exchanger effectiveness at the heating mode";
-  parameter Modelica.Units.SI.Efficiency epsSenHeaPL(final max=1) = 0.75
+  parameter Modelica.Units.SI.Efficiency epsSenHeaPL(final max=1)
     "Part load (75%) sensible heat exchanger effectiveness at the heating mode";
-  parameter Modelica.Units.SI.Efficiency epsLatHeaPL(final max=1) = 0.75
+  parameter Modelica.Units.SI.Efficiency epsLatHeaPL(final max=1)
     "Part load (75%) latent heat exchanger effectiveness at the heating mode";
   parameter Modelica.Units.SI.VolumeFlowRate VSup_flow_nominal
     "Nominal supply air flow rate";

diff --git a/Buildings/Fluid/HeatExchangers/ThermalWheels/BaseClasses/Validation/Effectiveness.mo b/Buildings/Fluid/HeatExchangers/ThermalWheels/BaseClasses/Validation/Effectiveness.mo
@@ -4,7 +4,9 @@ model Effectiveness
   extends Modelica.Icons.Example;
   Buildings.Fluid.HeatExchangers.ThermalWheels.BaseClasses.Effectiveness
     epsCal(
+    epsSenCoo_nominal=0.8,
     epsLatCoo_nominal=0.6,
+    epsSenCooPL=0.75,
     epsLatCooPL=0.7,
     epsSenHea_nominal=0.7,
     epsLatHea_nominal=0.6,

diff --git a/...eatExchangers/ThermalWheels/BaseClasses/Validation/HeatExchangerWithInputEffectiveness.mo b/...eatExchangers/ThermalWheels/BaseClasses/Validation/HeatExchangerWithInputEffectiveness.mo
@@ -49,8 +49,6 @@ model HeatExchangerWithInputEffectiveness
     hex(
     redeclare package Medium1 = Medium1,
     redeclare package Medium2 = Medium2,
-    m1_flow(start=5),
-    m2_flow(start=5),
     m1_flow_nominal=5,
     m2_flow_nominal=5,
     dp1_nominal=100,
@@ -85,9 +83,9 @@ equation
   connect(hex.port_b2, sin_2.ports[1])
     annotation (Line(points={{6,0},{-10,0},{-10,-20},{-20,-20}}, color={0,127,255}));
   connect(epsSen.y, hex.epsSen)
-    annotation (Line(points={{-59,20},{-20,20},{-20,10},{4,10}}, color={0,0,127}));
+    annotation (Line(points={{-59,20},{-20,20},{-20,9},{4,9}},   color={0,0,127}));
   connect(hex.epsLat, epsLat.y)
-    annotation (Line(points={{4,2},{-50,2},{-50,-40},{-59,-40}}, color={0,0,127}));
+    annotation (Line(points={{4,3},{-50,3},{-50,-40},{-59,-40}}, color={0,0,127}));
 
 annotation(experiment(Tolerance=1e-6, StopTime=360),
 __Dymola_Commands(file="modelica://Buildings/Resources/Scripts/Dymola/Fluid/HeatExchangers/ThermalWheels/BaseClasses/Validation/HeatExchangerWithInputEffectiveness.mos"