Updated test for BOM (#3030)

* Updated test for BOM This is for #3028
lbl-srg · May 24, 2022 · 8f5b8ad · 8f5b8ad
1 parent f99748a
commit 8f5b8ad
Show file tree

Hide file tree

Showing 23 changed files with 27 additions and 23 deletions.
diff --git a/.github/workflows/formatting.yml b/.github/workflows/formatting.yml
@@ -96,7 +96,11 @@ jobs:
               git diff --exit-code Buildings
 
       - name: Check for UTF-8 BOM
-        run: "! find . -name '*.mo' -print0 | xargs -0 grep -l $'^\\xEF\\xBB\\xBF' | grep ."
+        run : |
+              for ff in `grep -rlI --exclude="ffd.vcxproj" --exclude-dir="\.git" $'^\xEF\xBB\xBF' .`; do
+                echo "::error file=${ff}:: Found BOM in ${ff}."
+              done;
+              test -z "${ff}"
 
       - name: Check for file permissions
         run : |

diff --git a/Buildings/Examples/VAVReheat/Validation/BaseClasses/Floor.mo b/Buildings/Examples/VAVReheat/Validation/BaseClasses/Floor.mo
@@ -1,4 +1,4 @@
-within Buildings.Examples.VAVReheat.Validation.BaseClasses;
+within Buildings.Examples.VAVReheat.Validation.BaseClasses;
 model Floor
   "Extends Buildings.Examples.VAVReheat.BaseClasses.Floor with CO2 generation from people and CO2 from outside air."
   extends Buildings.Examples.VAVReheat.BaseClasses.Floor(

diff --git a/...ir/Systems/SingleZone/VAV/BaseClasses/Validation/ControllerChillerDXHeatingEconomizer.mos b/...ir/Systems/SingleZone/VAV/BaseClasses/Validation/ControllerChillerDXHeatingEconomizer.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.Air.Systems.SingleZone.VAV.BaseClasses.Validation.ControllerChillerDXHeatingEconomizer", stopTime=172800, tolerance=1e-06, resultFile="ControllerChillerDXHeatingEconomizer");
+simulateModel("Buildings.Air.Systems.SingleZone.VAV.BaseClasses.Validation.ControllerChillerDXHeatingEconomizer", stopTime=172800, tolerance=1e-06, resultFile="ControllerChillerDXHeatingEconomizer");
 createPlot(id=1, position={0, 0, 1316, 720}, y={"con.TSetRooCoo", "con.TSetRooHea", "con.TRoo"}, range={0.0, 175000.0, 10.0, 35.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}}, displayUnits={"degC", "degC", "degC"});
 createPlot(id=1, position={0, 0, 1316, 720}, y={"con.yFan", "con.yHea", "con.yCooCoiVal"}, range={0.0, 175000.0, -0.5, 1.5}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}}, displayUnits={"1", "1", "1"});
 createPlot(id=1, position={0, 0, 1316, 720}, y={"con.TSup", "con.TSetSupAir"}, range={0.0, 175000.0, 5.0, 25.0}, grid=true, subPlot=103, colors={{28,108,200}, {238,46,47}}, displayUnits={"degC", "degC"});

diff --git a/...rces/Scripts/Dymola/BoundaryConditions/GroundTemperature/Examples/CorrectedConvection.mos b/...rces/Scripts/Dymola/BoundaryConditions/GroundTemperature/Examples/CorrectedConvection.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.BoundaryConditions.GroundTemperature.Examples.CorrectedConvection", tolerance=1e-6, stopTime=31536000, method="Cvode", resultFile="CorrectedConvection");
+simulateModel("Buildings.BoundaryConditions.GroundTemperature.Examples.CorrectedConvection", tolerance=1e-6, stopTime=31536000, method="Cvode", resultFile="CorrectedConvection");
 createPlot(id=1, 
   position={16, 11, 592, 372}, 
   y={"TSoi[1].T", "TSoi[2].T", "TSoi[3].T", "TSoi[4].T"},

diff --git a/...ources/Scripts/Dymola/BoundaryConditions/GroundTemperature/Examples/CorrectedNFactors.mos b/...ources/Scripts/Dymola/BoundaryConditions/GroundTemperature/Examples/CorrectedNFactors.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.BoundaryConditions.GroundTemperature.Examples.CorrectedNFactors", tolerance=1e-6, stopTime=31536000, method="Cvode", resultFile="CorrectedNFactors");
+simulateModel("Buildings.BoundaryConditions.GroundTemperature.Examples.CorrectedNFactors", tolerance=1e-6, stopTime=31536000, method="Cvode", resultFile="CorrectedNFactors");
 createPlot(id=1, 
   position={16, 11, 592, 372}, 
   y={"TSoi[1].T", "TSoi[2].T", "TSoi[3].T", "TSoi[4].T"},

diff --git a/...ripts/Dymola/BoundaryConditions/GroundTemperature/Examples/UndisturbedSoilTemperature.mos b/...ripts/Dymola/BoundaryConditions/GroundTemperature/Examples/UndisturbedSoilTemperature.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.BoundaryConditions.GroundTemperature.Examples.UndisturbedSoilTemperature", tolerance=1e-6, stopTime=31536000, method="Cvode", resultFile="UndisturbedSoilTemperature");
+simulateModel("Buildings.BoundaryConditions.GroundTemperature.Examples.UndisturbedSoilTemperature", tolerance=1e-6, stopTime=31536000, method="Cvode", resultFile="UndisturbedSoilTemperature");
 createPlot(id=1, 
   position={16, 11, 592, 372}, 
   y={"TSoi[1].T", "TSoi[2].T", "TSoi[3].T", "TSoi[4].T"},

diff --git a/.../Scripts/Dymola/Controls/OBC/ASHRAE/G36_PR1/AHUs/SingleZone/VAV/Validation/Controller.mos b/.../Scripts/Dymola/Controls/OBC/ASHRAE/G36_PR1/AHUs/SingleZone/VAV/Validation/Controller.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Validation.Controller", method="Cvode", outputInterval=300, stopTime=86400, tolerance=1e-06, resultFile="conVAV");
+simulateModel("Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Validation.Controller", method="Cvode", outputInterval=300, stopTime=86400, tolerance=1e-06, resultFile="conVAV");
 createPlot(id=1, position={35, 30, 592, 427}, y={"conVAV.TSup", "conVAV.setPoiVAV.TSupHeaEco", "conVAV.setPoiVAV.TSupCoo"}, range={0.0, 90000.0, 0.0, 40.0}, grid=true, colors={{0,140,72}, {162,29,33}, {244,125,35}}, displayUnits={"degC", "degC", "degC"});
 createPlot(id=1, position={35, 30, 592, 104}, y={"conVAV.yRetDamPos", "conVAV.yOutDamPos", "conVAV.yFan","conVAV.yHeaCoi"}, range={0.0, 90000.0, -2.0, 2.0}, grid=true, subPlot=2, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}});
 createPlot(id=1, position={35, 30, 592, 103}, y={"conVAV.uOcc"}, range={0.0, 90000.0, -2.0, 2.0}, grid=true, subPlot=3, colors={{28,108,200}});

diff --git a/...Scripts/Dymola/Controls/OBC/ASHRAE/G36_PR1/AHUs/SingleZone/VAV/Validation/CoolingCoil.mos b/...Scripts/Dymola/Controls/OBC/ASHRAE/G36_PR1/AHUs/SingleZone/VAV/Validation/CoolingCoil.mos
@@ -1,3 +1,3 @@
-simulateModel("Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Validation.CoolingCoil", method="Cvode", outputInterval=300, stopTime=28000, tolerance=1e-06, resultFile="CoolingCoil");
+simulateModel("Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Validation.CoolingCoil", method="Cvode", outputInterval=300, stopTime=28000, tolerance=1e-06, resultFile="CoolingCoil");
 createPlot(id=1, position={0, 0, 1532, 791}, y={"cooCoi.yCooCoi"}, range={0.0, 28000.0, -0.2, 1.2000000000000002}, grid=true, colors={{28,108,200}});
 createPlot(id=1, position={0, 0, 1532, 393}, y={"TSupSet", "TSup.y"}, range={0.0, 28000.0, 15.5, 20.0}, grid=true, subPlot=2, colors={{28,108,200}, {238,46,47}}, displayUnits={"degC", "degC"});
diff --git a/...s/Scripts/Dymola/Controls/OBC/ASHRAE/G36_PR1/AHUs/SingleZone/VAV/Validation/ZoneState.mos b/...s/Scripts/Dymola/Controls/OBC/ASHRAE/G36_PR1/AHUs/SingleZone/VAV/Validation/ZoneState.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Validation.ZoneState", method="Cvode", stopTime=3, tolerance=1e-06, resultFile="ZoneStatePoints");
+simulateModel("Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Validation.ZoneState", method="Cvode", stopTime=3, tolerance=1e-06, resultFile="ZoneStatePoints");
 createPlot(id=1, position={55, 50, 592, 427}, y={"zonSta.yZonSta"}, range={0.0, 3.0, 0.0, 4.0}, grid=true, colors={{28,108,200}});
 createPlot(id=1, position={55, 50, 592, 211}, y={"zonSta.uHea", "zonSta.uCoo"}, range={0.0, 3.0, -0.5, 1.5}, grid=true, subPlot=2, colors={{28,108,200}, {238,46,47}});
 
diff --git a/...urces/Scripts/Dymola/Controls/OBC/Utilities/Validation/OptimalStartNoHeatingNoCooling.mos b/...urces/Scripts/Dymola/Controls/OBC/Utilities/Validation/OptimalStartNoHeatingNoCooling.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.Controls.OBC.Utilities.Validation.OptimalStartNoHeatingNoCooling", stopTime=2419200, method="Cvode", tolerance=1e-06, resultFile="OptimalStartNoHeatingNoCooling");
+simulateModel("Buildings.Controls.OBC.Utilities.Validation.OptimalStartNoHeatingNoCooling", stopTime=2419200, method="Cvode", tolerance=1e-06, resultFile="OptimalStartNoHeatingNoCooling");
 createPlot(id=1, position={10, 9, 1161, 1054},subPlot=1, y={"optSta.tOpt"}, range={0.0, 28.0, -1.5, 1.5}, grid=true, colors={{28,108,200}});
 createPlot(id=1, position={10, 9, 1161, 346},subPlot=2, y={"optSta.optOn"}, range={0.0, 2500000.0, -1.5, 1.5}, grid=true, colors={{28,108,200}});
 createPlot(id=1, position={10, 9, 1161, 346},subPlot=3, y={"TSetHea.y","TSetCoo.y","optSta.TZon"}, range={0.0, 2500000.0, 10.0, 35.0}, grid=true, colors={{238,46,47},{0,140,72},{28,108,200}});
diff --git a/Buildings/Resources/Scripts/Dymola/Examples/VAVReheat/Validation/TraceSubstance.mos b/Buildings/Resources/Scripts/Dymola/Examples/VAVReheat/Validation/TraceSubstance.mos
@@ -1,3 +1,3 @@
-simulateModel("Buildings.Examples.VAVReheat.Validation.TraceSubstance", startTime=4492800, stopTime=4665600, numberOfIntervals=0, outputInterval=900, method="Cvode", tolerance=1e-06, resultFile="TraceSubstance");
+simulateModel("Buildings.Examples.VAVReheat.Validation.TraceSubstance", startTime=4492800, stopTime=4665600, numberOfIntervals=0, outputInterval=900, method="Cvode", tolerance=1e-06, resultFile="TraceSubstance");
 createPlot(id=1, position={0, 0, 1537, 628}, y={"VOut1.V_flow", "senSupFlo.V_flow"}, range={3500000.0, 4650000.0, -0.5, 3.0}, grid=true, colors={{28,108,200}, {238,46,47}}, displayUnits={"m3/s", "m3/s"});
 createPlot(id=1, position={0, 0, 1537, 628}, y={"flo.cor.air.vol.C[1]", "flo.sou.air.vol.C[1]", "flo.eas.air.vol.C[1]", "flo.nor.air.vol.C[1]", "flo.wes.air.vol.C[1]"}, range={3500000.0, 4650000.0, -0.0005, 0.0015}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}});
diff --git a/.../Dymola/Experimental/DHC/CentralPlants/Cooling/Controls/Validation/ChilledWaterBypass.mos b/.../Dymola/Experimental/DHC/CentralPlants/Cooling/Controls/Validation/ChilledWaterBypass.mos
@@ -1,4 +1,4 @@
-// Simulate
+// Simulate
 simulateModel("Buildings.Experimental.DHC.CentralPlants.Cooling.Controls.Validation.ChilledWaterBypass", 
     stopTime=1200, 
     method="Cvode", 

diff --git a/...mola/Experimental/DHC/CentralPlants/Cooling/Controls/Validation/ChilledWaterPumpSpeed.mos b/...mola/Experimental/DHC/CentralPlants/Cooling/Controls/Validation/ChilledWaterPumpSpeed.mos
@@ -1,4 +1,4 @@
-// Simulate
+// Simulate
 simulateModel("Buildings.Experimental.DHC.CentralPlants.Cooling.Controls.Validation.ChilledWaterPumpSpeed",
 	stopTime=1200,
 	method="Cvode",

diff --git a/...cripts/Dymola/Experimental/DHC/CentralPlants/Cooling/Controls/Validation/ChillerStage.mos b/...cripts/Dymola/Experimental/DHC/CentralPlants/Cooling/Controls/Validation/ChillerStage.mos
@@ -1,4 +1,4 @@
-// Simulate
+// Simulate
 simulateModel("Buildings.Experimental.DHC.CentralPlants.Cooling.Controls.Validation.ChillerStage",
     stopTime=1200,
     method="Cvode",

diff --git a/Buildings/Resources/Scripts/Dymola/Experimental/DHC/CentralPlants/Cooling/Examples/Plant.mos b/Buildings/Resources/Scripts/Dymola/Experimental/DHC/CentralPlants/Cooling/Examples/Plant.mos
@@ -1,4 +1,4 @@
-// Simulate
+// Simulate
 simulateModel("Buildings.Experimental.DHC.CentralPlants.Cooling.Examples.Plant", 
     stopTime=86400, 
     method="cvode",

diff --git a/...mola/Experimental/DHC/CentralPlants/Cooling/Subsystems/Examples/CoolingTowersParallel.mos b/...mola/Experimental/DHC/CentralPlants/Cooling/Subsystems/Examples/CoolingTowersParallel.mos
@@ -1,4 +1,4 @@
-// Simulate
+// Simulate
 simulateModel("Buildings.Experimental.DHC.CentralPlants.Cooling.Subsystems.Examples.CoolingTowersParallel", 
 	startTime=15552000, 
 	stopTime=15724800, 

diff --git a/...la/Experimental/DHC/CentralPlants/Cooling/Subsystems/Examples/CoolingTowersWithBypass.mos b/...la/Experimental/DHC/CentralPlants/Cooling/Subsystems/Examples/CoolingTowersWithBypass.mos
@@ -1,4 +1,4 @@
-// Simulate
+// Simulate
 simulateModel("Buildings.Experimental.DHC.CentralPlants.Cooling.Subsystems.Examples.CoolingTowersWithBypass", 
 	startTime=10368000, 
 	stopTime=10540800, 

diff --git a/.../HeatExchangers/CoolingTowers/BaseClasses/Functions/Validation/EquivalentHeatCapacity.mos b/.../HeatExchangers/CoolingTowers/BaseClasses/Functions/Validation/EquivalentHeatCapacity.mos
@@ -1,4 +1,4 @@
-// Simulate
+// Simulate
 simulateModel("Buildings.Fluid.HeatExchangers.CoolingTowers.BaseClasses.Functions.Validation.EquivalentHeatCapacity", startTime=10, stopTime=20, method="CVode", tolerance=1e-6, resultFile="EquivalentHeatCapacity");
 // Plot commands
 removePlots(false);

diff --git a/...sources/Scripts/Dymola/Fluid/HeatExchangers/CoolingTowers/Validation/MerkelEnergyPlus.mos b/...sources/Scripts/Dymola/Fluid/HeatExchangers/CoolingTowers/Validation/MerkelEnergyPlus.mos
@@ -1,4 +1,4 @@
-// Simulate
+// Simulate
 simulateModel("Buildings.Fluid.HeatExchangers.CoolingTowers.Validation.MerkelEnergyPlus", stopTime=172800, tolerance=1E-6, method="CVode", resultFile="MerkelEnergyPlus");
 // Plot commands
 removePlots(false);

diff --git a/...ings/Resources/Scripts/Dymola/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTU.mos b/...ings/Resources/Scripts/Dymola/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTU.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.Fluid.HeatExchangers.Validation.WetCoilEffectivenessNTU",
+simulateModel("Buildings.Fluid.HeatExchangers.Validation.WetCoilEffectivenessNTU",
     stopTime=1000,
     method="cvode",
     tolerance=1e-6,

diff --git a/...sources/Scripts/Dymola/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTUHeating.mos b/...sources/Scripts/Dymola/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTUHeating.mos
@@ -1,4 +1,4 @@
-simulateModel("Buildings.Fluid.HeatExchangers.Validation.WetCoilEffectivenessNTUHeating",
+simulateModel("Buildings.Fluid.HeatExchangers.Validation.WetCoilEffectivenessNTUHeating",
     stopTime=1000,
     method="cvode",
     tolerance=1e-6,

diff --git a/Buildings/Resources/Scripts/Dymola/Obsolete/Examples/VAVReheat/Validation/VAVBranch.mos b/Buildings/Resources/Scripts/Dymola/Obsolete/Examples/VAVReheat/Validation/VAVBranch.mos
@@ -1,4 +1,4 @@
-// Script generated by Dymola Fri Feb 12 13:47:08 2021
+// Script generated by Dymola Fri Feb 12 13:47:08 2021
 // Simulate commands
 simulateModel("Buildings.Obsolete.Examples.VAVReheat.Validation.VAVBranch", stopTime=25200, method="Cvode", tolerance=1e-06, resultFile="VAVBranch");
 // Plot commands

diff --git a/Buildings/Resources/Scripts/Dymola/Utilities/IO/SignalExchange/Examples/FirstOrder.mos b/Buildings/Resources/Scripts/Dymola/Utilities/IO/SignalExchange/Examples/FirstOrder.mos
@@ -1,3 +1,3 @@
-simulateModel("Buildings.Utilities.IO.SignalExchange.Examples.FirstOrder", stopTime=150, tolerance=1e-6, method="CVode", resultFile="FirstOrder");
+simulateModel("Buildings.Utilities.IO.SignalExchange.Examples.FirstOrder", stopTime=150, tolerance=1e-6, method="CVode", resultFile="FirstOrder");
 createPlot(id=1, position={55, 50, 592, 427}, y={"expMod.oveWriSet_u", "expMod.oveWriAct_u", "expMod.rea"}, range={0.0, 150.0, -2.0, 4.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}});
 createPlot(id=1, position={55, 50, 592, 211}, y={"expMod.oveWriSet_activate", "expMod.oveWriAct_activate"}, range={0.0, 150.0, -0.5, 1.5}, grid=true, subPlot=2, colors={{28,108,200}, {28,108,200}});