Issue2510 main91x pipe autosize dh min (#3178)

* Copy changes from PR3163 * Add Documentation annotation to new Validation package * Update min attribute to 0.001
lbl-srg · Dec 2, 2022 · 756d658 · 756d658
1 parent 6c24df3
commit 756d658
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/Buildings/Experimental/DHC/Networks/Combined/BaseClasses/PipeAutosize.mo b/Buildings/Experimental/DHC/Networks/Combined/BaseClasses/PipeAutosize.mo
@@ -7,7 +7,7 @@ model PipeAutosize "Pipe model parameterized with pressure drop per pipe length"
   parameter Modelica.Units.SI.Length dh(
     fixed=false,
     start=0.01,
-    min=0.01) "Hydraulic diameter (assuming a round cross section area)";
+    min=0.001) "Hydraulic diameter (assuming a round cross section area)";
 
   parameter Real dp_length_nominal(final unit="Pa/m") = 250
     "Pressure drop per pipe length at nominal flow rate";
@@ -101,7 +101,8 @@ depends on <code>dp_nominal</code> and must be evaluated at compile time.
 <ul>
 <li>
 November 18, 2022, by David Blum:<br/>
-Start attribute for parameter dh changed to 0.01.<br/>
+<code>start</code> attribute for parameter <code>dh</code> changed to 0.01.<br/>
+<code>min</code> attribute for parameter <code>dh</code> changed to 0.001.<br/>
 This is for <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/2510\">issue 2510</a>.
 </li>
 <li>

diff --git a/Buildings/Resources/Scripts/BuildingsPy/conf.yml b/Buildings/Resources/Scripts/BuildingsPy/conf.yml
@@ -140,10 +140,6 @@
   optimica:
     comment: The rootfinding function failed in an unrecoverable manner. At time 5959.741337. (Radau5ODE fails at 3540.029280) (but works locally)
     simulate: false
-- model_name: Buildings.Experimental.DHC.Networks.Combined.BaseClasses.Validation.Pipe
-  optimica:
-    comment: Could not solve initialization. Could not bracket the root. Iteration variable pipAut1.dh. Filed Modelon#2022112839000242
-    simulate: false
 - model_name: Buildings.Experimental.DHC.Plants.Cooling.Examples.ElectricChillerParallel
   openmodelica:
     comment: 'division by zero at time 0, (a=0) / (b=0), where divisor b expression is: 0.0'

diff --git a/Buildings/package.mo b/Buildings/package.mo
@@ -403,7 +403,8 @@ have been <b style=\"color:blue\">improved</b> in a
 </tr>
 <tr><td valign=\"top\">Buildings.Experimental.DHC.Networks.Combined.BaseClasses.PipeAutosize
     </td>
-    <td valign=\"top\">Start attribute for parameter <code>dh</code> changed to 0.01.<br/>
+    <td valign=\"top\"><code>start</code> attribute for parameter <code>dh</code> changed to 0.01.<br/>
+                       <code>min</code> attribute for parameter <code>dh</code> changed to 0.001.<br/>
                        This is for <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/2510\">issue #2510</a>.
     </td>
 </tr>