Skip to content

Commit

Permalink
updated existing BESTEST cases and added new cases (#3032)
Browse files Browse the repository at this point in the history
* updated to latest BESTEST

* added release note and revision note for the CenterOfGlass class

* Corrected air pressure to be the same as in weather data file

This required adding a small flow resistance to decouple the pressure boundary condition from the room model. Annual cooling for Case 900 changes by 4%.


* Added models to exclude list

Co-authored-by: Michael Wetter <[email protected]>
  • Loading branch information
JayHuLBL and mwetter authored May 27, 2022
1 parent 55dea13 commit 4f21177
Show file tree
Hide file tree
Showing 158 changed files with 13,467 additions and 1,828 deletions.
10 changes: 9 additions & 1 deletion Buildings/HeatTransfer/Windows/BaseClasses/CenterOfGlass.mo
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ model CenterOfGlass "Model for center of glass of a window construction"
final gas=glaSys.gas,
each final til=til,
each linearize=linearize,
each final homotopyInitialization=homotopyInitialization)
each final homotopyInitialization=homotopyInitialization) if have_GasLay
"Window gas layer"
annotation (Placement(transformation(extent={{20,10},{40,30}})));

Expand All @@ -64,6 +64,8 @@ model CenterOfGlass "Model for center of glass of a window construction"
protected
final parameter Integer nGlaLay = size(glaSys.glass, 1)
"Number of glass layers";
final parameter Boolean have_GasLay = nGlaLay > 1
"True if it has gas layer";

initial equation
assert(homotopyInitialization, "In " + getInstanceName() +
Expand Down Expand Up @@ -209,6 +211,12 @@ Buildings.HeatTransfer.Windows.InteriorHeatTransferConvective</a>.
revisions="<html>
<ul>
<li>
May 24, 2022, by Jianjun Hu:<br/>
Changed the gas layer to be conditional.<br/>
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3026\">#3026</a>.
</li>
<li>
April 14, 2020, by Michael Wetter:<br/>
Changed <code>homotopyInitialization</code> to a constant.<br/>
This is for
Expand Down
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
last-generated=2021-12-15
last-generated=2022-05-24
statistics-initialization=
{
"linear": "19",
"nonlinear": "14",
"nonlinear": "1, 1, 1, 1, 1, 1, 13",
"numerical Jacobians": "0"
}
statistics-simulation=
{
"linear": "0, 0, 11, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0",
"nonlinear": " ",
"number of continuous time states": "59",
"linear": "0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0",
"nonlinear": "1, 1, 1, 1, 1, 1, 1, 11, 1",
"number of continuous time states": "42",
"numerical Jacobians": "0"
}
time=[0e+00, 2.6784e+06]
preErr.u1=[0e+00, 0e+00, 0e+00, 0e+00, 2.185425048828125e+03, 0e+00, 9.795061645507812e+02, 2.938868896484375e+03, 3.67384765625e+03, 3.254244384765625e+03, 4.17325048828125e+03, 3.76612646484375e+03, 1.800514526367188e+03, 3.47683740234375e+03, 2.3046201171875e+03, 2.001055603027344e+02, 1.919657836914062e+03, 2.213864501953125e+03, -4.098386764526367e+01, 1.393405639648438e+03, 2.5510546875e+03, 1.354099731445312e+02, 5.315731201171875e+02, 2.480039794921875e+03, 4.206732482910156e+02, -1.380255603790283e+01, 2.149153076171875e+03, 1.248575561523438e+03, -5.003417205810547e+01, 1.79872509765625e+03, 1.63809912109375e+03, -1.285071563720703e+02, 1.942593383789062e+03, 1.634063720703125e+03, -6.10038948059082e+01, 5.471179809569866e+02, 1.97353076171875e+03, 1.18548412322998e+01, -1.767942199707031e+02, 1.7811083984375e+03, 1.160085601806641e+02, -1.841914825439453e+02, 1.221525024414062e+03, 1.625897338867188e+03, 0e+00, 2.7028544921875e+03, 2.73646875e+03, 0e+00, 2.31684912109375e+03, 2.997369873046875e+03, 2.130341949462891e+02, 8.638154029846191e+00, 1.980752563476562e+03, 1.786717071533203e+02, 8.393498992919922e+01, 1.3389013671875e+03, 6.021799926757812e+02, 5.180568695064172e-01, 1.503193115234375e+03, 1.922961547851562e+03, 0e+00, 2.111289794921875e+03, 2.272830322265625e+03, 4.333543395996094e+02, 3.3941669921875e+03, 3.393877197265625e+03, 9.66173095703125e+02, 1.329028686523438e+03, 2.506179443359375e+03, 4.409668579102971e+02, 2.653961181640655e+02, 2.0721455078125e+03, 2.02718408203125e+03, -7.395858764648438e+01, 1.400580078125e+03, 1.924262329101562e+03, -3.143888854980469e+02, -1.832602310180664e+01, 1.486926635742188e+03, -1.190875473022461e+02, 3.010773620605469e+02, 1.83116455078125e+03, 5.287991333007812e+02, 4.988869018554688e+02, 2.442748291015625e+03, 1.1813828125e+03, 2.526815338134766e+02, 1.999979125976562e+03, 1.500876831054688e+03, -3.330752182006836e+01, 7.235758056640625e+02, 2.0901796875e+03, 4.577451782226562e+02, 1.29251953125e+03, 2.797715087890625e+03, 6.222782592773438e+02, 5.618646240234375e+02, 2.4259755859375e+03, 2.322345581054688e+02, 0e+00, 2.728402099609375e+03]
preErr.u2=[0e+00, 1.632307983398438e+03, 0e+00, 1.564184326171875e+03, 2.8563583984375e+03, 2.898925537109375e+03, 3.60548828125e+03, 3.670684326171875e+03, 7.59306396484375e+02, 3.141818115234375e+03, 4.16286767578125e+03, 5.5183935546875e+02, 0e+00, 3.663645751953125e+03, 1.749791137695279e+03, 0e+00, 2.014662475585938e+03, 2.107529541015625e+03, 0e+00, 1.231146484375e+03, 2.0510556640625e+03, 0e+00, 7.838233642578125e+02, 2.24844580078125e+03, 0e+00, 0e+00, 2.307877197265625e+03, 0e+00, 0e+00, 1.776161376953125e+03, 1.642391357421875e+03, 0e+00, 1.494694580078125e+03, 1.656671630859375e+03, 0e+00, 6.912013549804442e+02, 1.925573486328125e+03, 0e+00, 0e+00, 1.818729736328125e+03, 0e+00, 0e+00, 1.268410522460938e+03, 1.7977255859375e+03, 0e+00, 2.34177587890625e+03, 2.77284326171875e+03, 0e+00, 2.683800048828125e+03, 2.93024658203125e+03, 0e+00, 3.676320495605469e+02, 1.85924365234375e+03, 0e+00, 0e+00, 1.582552368164046e+03, 0e+00, 0e+00, 1.72408837890625e+03, 1.922219970703125e+03, 1.39984326171875e+03, 1.998545166015625e+03, 2.312189697265625e+03, 1.994189575195312e+03, 3.00730712890625e+03, 3.58184765625e+03, 0e+00, 5.560128173828125e+02, 2.702902832031251e+03, 0e+00, 0e+00, 2.210910400390625e+03, 1.530176147460938e+03, 0e+00, 1.577363647460938e+03, 1.910183227539062e+03, 0e+00, 0e+00, 1.619625122070312e+03, 0e+00, 0e+00, 1.731020141601562e+03, 1.668677368164062e+03, 0e+00, 2.4775703125e+03, 4.663446960449219e+02, 0e+00, 2.016747680664062e+03, 1.49632275390625e+03, 0e+00, 1.007379455566406e+03, 2.089607421875e+03, 0e+00, 1.503521118164062e+03, 2.758639892578125e+03, 0e+00, 4.876479797363281e+02, 2.302613037109375e+03, 1.487220458984375e+03, 0e+00, 2.667860595703125e+03]
preErr.y=[0e+00, -4.080770015716553e-01, 0e+00, -3.910460770130157e-01, -1.677333414554596e-01, -7.247313857078552e-01, -6.564955115318298e-01, -1.829538643360139e-01, 7.28635311126709e-01, 2.810652554035187e-02, 2.595731988549232e-03, 8.035717606544495e-01, 4.501286447048187e-01, -4.670208320021629e-02, 1.387072652578438e-01, 5.002639070153236e-02, -2.37511619925499e-02, 2.658377401530737e-02, -1.02459667250514e-02, 4.056479781866074e-02, 1.249997466802597e-01, 3.385249525308609e-02, -6.306254863739014e-02, 5.789846181869507e-02, 1.051683127880096e-01, -3.450639080256224e-03, -3.968099132180214e-02, 3.121438920497894e-01, -1.250854227691889e-02, 5.640923976898193e-03, -1.073047169484198e-03, -3.212678804993629e-02, 1.119747087359428e-01, -5.651977378875017e-03, -1.52509743347764e-02, -3.602084890008477e-02, 1.198931410908699e-02, 2.963710343465209e-03, -4.419855400919914e-02, -9.405333548784256e-03, 2.900214120745659e-02, -4.60478737950325e-02, -1.172137726098299e-02, -4.295707866549492e-02, 0e+00, 9.026966243982315e-02, -9.093604050576687e-03, 0e+00, -9.173772484064102e-02, 1.678087003529072e-02, 5.325854569673538e-02, -8.974847197532654e-02, 3.037724085152149e-02, 4.466792568564415e-02, 2.09837481379509e-02, -6.091274321078848e-02, 1.505449861288071e-01, 1.295142137677293e-04, -5.522382259368896e-02, 1.854121364885941e-04, -3.499608039855957e-01, 2.818617038428783e-02, -9.839833714067936e-03, -3.902088105678558e-01, 9.671496599912643e-02, -4.699259623885155e-02, 2.415432631969452e-01, 1.932539641857147e-01, -4.91808541119101e-02, 1.102417111397142e-01, 6.634902954101637e-02, -3.469124436378479e-02, 1.24252013862133e-01, -1.8489645794034e-02, -4.419589042663574e-02, 3.519792342558503e-03, -7.859721779823303e-02, -4.58150589838624e-03, -3.317460417747498e-02, -2.977188676595688e-02, 7.526934146881104e-02, 2.503611519932747e-02, -2.849695682525635e-01, 1.247217282652855e-01, -8.705506101250648e-03, 1.787595152854919e-01, 6.317038089036942e-02, -4.192128777503967e-03, 1.1385059915483e-03, -8.326880633831024e-03, -7.095091789960861e-02, 1.431148266419768e-04, 1.144362911581993e-01, -5.275041982531548e-02, 9.768802672624588e-03, 1.555695682764053e-01, 1.855415105819702e-02, 3.084063157439232e-02, -3.137464821338654e-01, 0e+00, 1.513532642275095e-02]
preErr.u1=[0e+00, 0e+00, 0e+00, 0e+00, 2.323864013671875e+03, 0e+00, 1.347915283203125e+03, 1.579509765625e+03, 0e+00, 3.771401062011719e+02, 2.88286083984375e+03, 5.6700830078125e+02, -3.042687892913818e+00, 2.078848388671875e+03, 5.381057739257812e+02, 6.949165344238281e+01, 1.321990234375e+03, 1.62054296875e+03, 3.691921997070312e+01, 1.494279541015625e+03, 2.96714306640625e+03, 9.665821075439453e+01, 6.049066772460938e+02, 1.647890747070312e+03, 2.122649993896484e+02, 2.650663146972656e+02, 1.747499633789062e+03, 1.28401171875e+03, 1.301346282958984e+02, 1.525666748046875e+03, 2.190502685546875e+03, 8.922792816162109e+01, 1.41635009765625e+03, 2.206837890625e+03, 9.436099243164062e+01, 6.604697875976349e+02, 1.57621240234375e+03, 1.896690826416016e+02, 3.345641174316406e+02, 1.48354931640625e+03, 2.240098571777344e+02, 3.830892639160156e+02, 1.121524047851562e+03, 8.552015380859375e+02, 7.482384490966797e+01, 1.092846435546875e+03, 1.78160302734375e+03, 4.848930740356445e+01, 8.569365844726562e+02, 1.583349975585938e+03, 4.090372619628906e+02, 4.311004943847656e+02, 1.82636279296875e+03, 5.743228149414062e+02, 3.179374389648438e+02, 2.5298271484375e+03, 2.0152783203125e+03, 7.814869689940291e+01, 4.099170227050781e+02, 1.136255004882812e+03, 5.127048492431641e+01, 1.195282348632812e+03, 2.12314208984375e+03, 5.311600875854492e+01, 7.70343994140625e+02, 2.223500244140625e+03, 7.089375305175781e+01, 2.958970069885254e+01, 1.57068798828125e+03, 2.652348327637649e+02, 4.634131240844704e+01, 1.431195434570312e+03, 1.522260498046875e+03, 0e+00, 1.355202026367188e+03, 1.291630126953125e+03, 0e+00, 1.744229583740234e+02, 1.743539184570312e+03, 0e+00, 1.358989715576172e+02, 1.753810180664062e+03, 9.682813262939453e+01, 7.694832324981689e+00, 2.027652465820312e+03, 6.57020263671875e+02, 0e+00, 2.407577880859375e+03, 2.29062939453125e+03, 0e+00, 1.980937744140625e+03, 2.705692138671875e+03, 0e+00, 1.420598266601562e+03, 2.55992919921875e+03, 3.156709671020508e+01, 2.991243286132812e+02, 2.194080810546875e+03, 2.876688842773438e+02, 0e+00, 1.91667626953125e+03]
preErr.u2=[0e+00, 2.4818955078125e+03, 0e+00, 2.078849853515625e+03, 2.26084033203125e+03, 0e+00, 1.148614868164062e+03, 1.826117065429688e+03, 0e+00, 1.159320922851562e+03, 2.834509033203125e+03, 9.03371826171875e+02, 5.044135437011719e+02, 1.09161181640625e+03, 2.622672424316356e+02, 0e+00, 1.453168334960938e+03, 1.731753051757812e+03, 0e+00, 1.791226196289062e+03, 2.605173583984375e+03, 8.896436767578125e+02, 1.194987426757812e+03, 1.629510498046875e+03, 0e+00, 0e+00, 1.912000366210938e+03, 8.893793487548828e+01, 0e+00, 1.879064819335938e+03, 2.119072021484375e+03, 0e+00, 1.626188354492188e+03, 2.154130615234375e+03, 0e+00, 5.816683349609199e+02, 1.733721069335938e+03, 8.83598388671875e+02, 1.318162109375e+03, 1.527754516601562e+03, 0e+00, 0e+00, 1.310124145507812e+03, 8.853671264648438e+02, 0e+00, 1.314303100585938e+03, 1.837090087890625e+03, 0e+00, 7.617918701171875e+02, 1.528598754882812e+03, 0e+00, 6.369301147460938e+02, 1.826255981445312e+03, 2.359108123779297e+02, 0e+00, 2.649584472656252e+03, 6.464780883787901e+02, 0e+00, 6.528807983398438e+02, 1.004587158203125e+03, 0e+00, 1.321634765625e+03, 2.1490146484375e+03, 0e+00, 5.942556762695312e+02, 2.199564453125e+03, 0e+00, 0e+00, 1.554806762695318e+03, 0e+00, 0e+00, 1.591955932617188e+03, 1.398425415039062e+03, 0e+00, 1.114667236328125e+03, 1.2793837890625e+03, 0e+00, 5.159749755859375e+02, 1.767095947265625e+03, 0e+00, 0e+00, 1.610708374023438e+03, 4.060807800292969e+02, 0e+00, 1.938532958984375e+03, 1.005926879882812e+03, 0e+00, 1.984948486328125e+03, 2.292039306640625e+03, 0e+00, 1.936336547851562e+03, 2.78570361328125e+03, 0e+00, 1.547747680664062e+03, 2.5921123046875e+03, 0e+00, 0e+00, 2.15956103515625e+03, 1.143361450195312e+03, 0e+00, 2.116067626953125e+03]
preErr.y=[0e+00, -6.204739212989807e-01, 0e+00, -5.19712507724762e-01, 1.575593650341034e-02, 0e+00, 4.982509836554527e-02, -6.165181472897536e-02, 0e+00, -1.955451965332031e-01, 1.208793465048075e-02, -8.409088104963303e-02, -1.268640607595444e-01, 2.468091696500778e-01, 6.895962357521183e-02, 1.737291179597378e-02, -3.27945202589035e-02, -2.78025008738041e-02, 9.229805320501328e-03, -7.42366760969162e-02, 9.049238264560699e-02, -1.982463598251343e-01, -1.475201994180679e-01, 4.595056641846895e-03, 5.306624993681908e-02, 6.626658141613007e-02, -4.112517833709717e-02, 2.987684309482574e-01, 3.253365680575371e-02, -8.834952861070633e-02, 1.785763539373875e-02, 2.230698242783546e-02, -5.245954543352127e-02, 1.317683141678572e-02, 2.359024807810783e-02, 1.970036886632348e-02, -3.937715664505959e-02, -1.734823286533356e-01, -2.45899498462677e-01, -1.105130650103092e-02, 5.600246414542198e-02, 9.577231854200363e-02, -4.715002700686455e-02, -7.541383616626263e-03, 1.870596036314964e-02, -5.536414310336113e-02, -1.387177128344774e-02, 1.212232653051615e-02, 2.378618158400059e-02, 1.368782389909029e-02, 1.022593155503273e-01, -5.145739391446114e-02, 2.670803041837644e-05, 8.460300415754318e-02, 7.948436588048935e-02, -2.993929758668008e-02, 3.422000706196122e-01, 1.953717321157177e-02, -6.074094399809837e-02, 3.291697427630424e-02, 1.28176212310791e-02, -3.158809617161751e-02, -6.468167528510094e-03, 1.327900215983391e-02, 4.40220832824707e-02, 5.983960814774036e-03, 1.772343926131725e-02, 7.39742536097765e-03, 3.970309626309774e-03, 6.630870699884833e-02, 1.158532779663795e-02, -4.019013419747353e-02, 3.095877729356289e-02, 0e+00, 6.01336807012558e-02, 3.06160538457334e-03, 0e+00, -8.538801223039627e-02, -5.889169871807098e-03, 0e+00, 3.397474437952042e-02, 3.577545285224915e-02, -7.731316238641739e-02, 1.923708012327552e-03, 2.227988839149475e-02, -8.722665160894394e-02, 0e+00, 1.056573465466499e-01, -3.524617059156299e-04, 0e+00, 1.115030236542225e-02, -2.000282146036625e-02, 0e+00, -3.178736194968224e-02, -8.045803755521774e-03, 7.89177417755127e-03, 7.478108257055283e-02, 8.629937656223774e-03, -2.139231413602829e-01, 0e+00, -4.984781891107559e-02]
Loading

0 comments on commit 4f21177

Please sign in to comment.