Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Added various images for the dark and light theme for the Layer5 website also removed unwanted code within the SVG Files. #6120

Closed
wants to merge 42 commits into from

Conversation

Ajay-singh1
Copy link
Member

@Ajay-singh1 Ajay-singh1 commented Dec 10, 2024

Description

Signed commits

  • Yes, I signed my commits.

@Ajay-singh1 Ajay-singh1 changed the title Removed unnecessary boolean condition Fix image issue Dec 10, 2024
@l5io
Copy link
Contributor

l5io commented Dec 10, 2024

🚀 Preview for commit 997abdb at: https://6758565d60435f6227f0395a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 10, 2024

🚀 Preview for commit cb06ee8 at: https://675862cf3aba0800813f5053--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit bf31c1c at: https://675a4807577d84cf83b2cb1c--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as draft December 12, 2024 02:27
@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit a223d57 at: https://675a4cc74b7dd2c9047354f6--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit 1d54ea2 at: https://675a55026eb9b79af7a67bbf--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit 94c84b3 at: https://675a5c2e4b7dd2dcdf735178--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit dbe16d7 at: https://675a691eb7f803f2d960ab50--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as ready for review December 12, 2024 04:48
@Ajay-singh1
Copy link
Member Author

@leecalcote Indeed their was a PNG File within this SVG I have fixed it.

@Ajay-singh1
Copy link
Member Author

🚀 Preview for commit dbe16d7 at: https://675a691eb7f803f2d960ab50--layer5.netlify.app

Final Result.

@l5io
Copy link
Contributor

l5io commented Dec 13, 2024

🚀 Preview for commit ce4ee09 at: https://675ba2e46168b35f98b78323--layer5.netlify.app

@mdkaifansari04
Copy link
Contributor

Looks good @Ajay-singh1, dark and light svg is also working 👍

@vishalvivekm
Copy link
Contributor

@Ajay-singh1
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ajay-singh1 why this light mode for the aws only? not other ones like GCP and kubernetes? And why only on the one part and not on the whole page we should use dark and light mode images?

@Ajay-singh1
Copy link
Member Author

Ajay-singh1 commented Dec 19, 2024

@sudhanshutech Done!

@l5io
Copy link
Contributor

l5io commented Dec 19, 2024

🚀 Preview for commit d10feb7 at: https://6763b7a7cbfd661d050ecd80--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 19, 2024

🚀 Preview for commit 3dcfeb9 at: https://6763cba72fc6d46eb810ba71--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 19, 2024

🚀 Preview for commit ed8522c at: https://67641fd866069e221f0ebf33--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 19, 2024

🚀 Preview for commit ab25f0f at: https://676428b6015266389a663dec--layer5.netlify.app

@leecalcote
Copy link
Member

Please update the title of this PR to be more descriptive of its purpose and area of focus.

@Ajay-singh1 Ajay-singh1 changed the title Fix image issue Added various images for dark and light mode also fixed svg issue Dec 19, 2024
@Pratik-050
Copy link

Hello @sudhanshutech @leecalcote I was going through this PR when I saw that there are no GIFs for light mode in the repo, we can add light GIFs for better consistency in the light theme.
Screenshot from 2024-12-20 00-14-40

@Ajay-singh1 Ajay-singh1 requested review from sudhanshutech and removed request for sudhanshutech December 20, 2024 04:32
@l5io
Copy link
Contributor

l5io commented Dec 21, 2024

🚀 Preview for commit f42e9b4 at: https://6766bd0b44e08b4fb42280b7--layer5.netlify.app

leecalcote and others added 22 commits December 25, 2024 05:10
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
…ed clarity and organization

Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Ajay Singh <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.