Skip to content

Tabbed content visibility #599 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

HIMU-2001
Copy link
Contributor

Notes for Reviewers

Enhanced the visibility of the tabbed panel.

This PR fixes #599

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 5833108
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/6859618e7ce45f000879fd34
😎 Deploy Preview https://deploy-preview-609--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: HIMANSHU RAI <[email protected]>
@HIMU-2001 HIMU-2001 force-pushed the tabbed-content-visibility branch from 3b1c429 to 3114377 Compare June 18, 2025 00:54
HIMU-2001 and others added 3 commits June 18, 2025 06:29
Signed-off-by: Himanshu Rai <[email protected]>
Signed-off-by: HIMANSHU RAI <[email protected]>
Signed-off-by: HIMANSHU RAI <[email protected]>
Copy link
Contributor

@zihanKuang zihanKuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HIMU-2001 , great job!

Regarding the original issue, we've observed that when multiple tabs are present, the unselected tabs can easily be overlooked.😶‍🌫️

Do you have any thoughts on how we could enhance the visual presence of these inactive tabs? Perhaps adjusting their background color could make them stand out more. We could consider giving them a consistent background, similar to the clickable tags shown on the right side of the page. Or, if you have any better ideas, please feel free to share!

image
image

Signed-off-by: HIMANSHU RAI <[email protected]>
@HIMU-2001
Copy link
Contributor Author

Hi @zihanKuang ,

Thank you for the feedback! I've made some modifications as you suggested, particularly adjusting the background color of the inactive tabs. Could you please take a look and let me know your thoughts?

@zihanKuang zihanKuang requested a review from vishalvivekm June 23, 2025 09:39
@vishalvivekm
Copy link
Contributor

@HIMU-2001
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@vr-varad
Copy link
Contributor

image
I dont think the Sort By is a tab
@HIMU-2001

Signed-off-by: HIMANSHU RAI <[email protected]>
@HIMU-2001
Copy link
Contributor Author

Hi @vr-varad ,

image

Now the sort by can be distinguished seperately

@vr-varad vr-varad requested a review from zihanKuang June 23, 2025 14:19
@vr-varad
Copy link
Contributor

@vishalvivekm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance tabbed content visibility
4 participants