Add support for both attributes and message attributes #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of Attribute parameters Null safe
|
Thanks for adding this capability @acartcat. Let me check if it is possible to resolve a string to array without us doing it explicitly in the code. Other than that, it looks ok to me. I take it you have tested it locally? |
laveeshb
requested changes
Mar 3, 2021
| <PackageReference Include="AWSSDK.SQS" Version="3.5.1.8" /> | ||
| <PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.14" /> | ||
| <PackageReference Include="AWSSDK.SQS" Version="3.5.1.21" /> | ||
| <PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.25" /> |
There was a problem hiding this comment.
why are we updating the version of webjobs SDK? Is there a dependency on 3.0.25 for this functionality? If not, I would prefer to use as low a version as possible, so it imposes least restrictions.
There was a problem hiding this comment.
Sorry, so long to respond. I'm fine with the choice of webjobs SDK. I have this running and receiving messages. It's been running for months with low message volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this in a POC for an Azure Function taking telemetry from an SQS queue. It's important to get the Message Attributes and the other attributes. Let me know what you think. I couldn't work out if it was possible to use a List directly as a parameter so reverted to Split() on the string
Cheers