Enable tutorials on Windows #259
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awintel
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Thanks, I'm fine with the basic mechanism for now.
However, it would be nice to beautify it a bit more:
- Please come up with a better name for enable_win. Sounds very hack'ish. It should probably also not be in the in_depth directory if it's needed for any tutorial. Probably should go into utils?
- Please rework this statement:
"This is not part of the tutorial or Lava, but to allow this jupyter notebook to execute on Windows without errors. The class LIF and PyLifModel need to be imported from a script in order to run this tutorial on Windows due to an issue with the multiprocessing package on Windows."
-> You say it's not part of the tutorial, yet is all written within a Lava tutorial. Just give a bit of a cleaner explanation as to why such a hack is necessary and that we'll look into fixing this in the future.
-> Text says LIF AND PyLifModel need to be imported but you only import LIF - Can you think of a way to hide all this import business? Would it be possible to just have a single function to which you pass the class of function name of a class of function defined in a tutorial. It then detects the local file it is defined in, exports it, and reimports it into the global namespace?
tutorials/in_depth/win_exec.py
Outdated
| import os | ||
|
|
||
|
|
||
| def enable_win(nb_name: str): |
There was a problem hiding this comment.
Please come up with a better name.
tutorials/in_depth/win_exec.py
Outdated
|
|
||
|
|
||
| def enable_win(nb_name: str): | ||
| """Enables execution of Lava tutorials on Windows systems. Processes |
There was a problem hiding this comment.
Please give better justification for this workaround.
Provide a bit of context why such a strange hack is necessary. If people are not just told what is done by why it is done, it's easier to "accept".
|
I realized that the solution only works for tutorial 02, for the other tutorials things get more complex because Processes get overwritten. There is some cleanup necessary, but @awintel, could you please take a look at this updated solution? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #95 and #148
Objective of pull request: All tutorials should work on Windows systems
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?