-
Notifications
You must be signed in to change notification settings - Fork 9
Update & refactor, support for maintainer mapping #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
durw4rd
commented
May 9, 2025
- Improved folder structure
- Added typescript and deno configuration files
- Added support for assigning maintainers to flags in the target project
- Added support for optionally mapping maintainer IDs for cross-account project migrations
- Updated readme to reflect the changes
…Id to the new flags; add support for mapping maintainer IDs for cross-account migrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the folder structure and refactors scripts to improve project migration, including adding support for maintainer ID mapping. Key changes include:
- Introducing update_maintainers.ts to update maintainer IDs in flag data using a JSON mapping file.
- Refactoring file paths across scripts (source.ts and migrate.ts) to reflect the new project structure.
- Updating the README to document new configuration, usage instructions, and Deno tasks.
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/scripts/update_maintainers.ts | New script for updating maintainer IDs based on a mapping file |
src/scripts/source.ts | Updated import paths and output directory to match the new structure |
src/scripts/migrate.ts | Updated import paths and directory references; added optional maintainerId flag |
README.md | Expanded documentation to include the new file structure, tasks, and usage |
Files not reviewed (4)
- .vscode/settings.json: Language not supported
- config/deno.json: Language not supported
- config/import_map.json: Language not supported
- config/tsconfig.json: Language not supported
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the project structure and enhances functionality to support updating and migrating maintainer mappings along with other project data. Key changes include improved folder organization, the addition of TypeScript and Deno configuration files, and updates to scripts (source, update_maintainers, migrate) to support maintainer mapping and cross-account migrations.
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/scripts/update_maintainers.ts | Implements maintainer mapping updates for local flag JSON files. |
src/scripts/source.ts | Updates folder path and refactors import paths for clarity. |
src/scripts/migrate.ts | Refactors migration script with updated file paths, logging, and type annotations. |
README.md | Updates documentation to reflect changes in structure and usage. |
Files not reviewed (4)
- .vscode/settings.json: Language not supported
- config/import_map.json: Language not supported
- config/tsconfig.json: Language not supported
- deno.json: Language not supported
Comments suppressed due to low confidence (1)
src/scripts/migrate.ts:302
- The makePatchCall function logs the patch status twice (once conditionally and once unconditionally). Consider removing one of the consoleLogger calls to avoid redundant logging.
consoleLogger(flagPatchStatus, ` Patching ${flagKey} with environment [${env}] specific configuration, Status: ${flagPatchStatus}`);
Setup a deno project Add a script to patch maintainers Bump up the limit for the number of segment fetched
…logging in case of errors