Skip to content

Fix NoHostnameTlsVerifier for rustls 0.23.24 and above #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NoHostnameTlsVerifier for rustls 0.23.24 and above #3861

wants to merge 1 commit into from

Conversation

elichai
Copy link

@elichai elichai commented May 15, 2025

From Rustls 0.23.24 release:

New feature: More detailed and helpful error reporting for common certificate errors, such as name mismatches and certificate expiry. Users who std::fmt::Display the rustls Error type will take advantage of this automatically. Users handling CertificateError variants individually should note the new variants, such as CertificateError::NotValidForNameContext (compare CertificateError::NotValidForName).

This fixes the NoHostnameTlsVerifier by also matching on this new variant.

Fixes #3793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NoHostnameTlsVerifier does not work with rustls v0.23.24 or later
1 participant
@elichai