Skip to content

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented May 12, 2025

deployCustomWorld returns stateBlock that is at world contract creation, but that is before initialization or ownership transfer

Currently deploying a new customWorld doesn't work because ensureNamespaceOwner gets this early stateBlock and doesn't see the updated ownership

In addition to the fix I add an e2e test for a simple CustomWorld identical to the normal world, to test that deployCustomWorld works at all (you can see it fail if you revert the fix)

Copy link

changeset-bot bot commented May 12, 2025

⚠️ No Changeset found

Latest commit: 9faa5d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dk1a dk1a marked this pull request as ready for review May 12, 2025 18:01
@dk1a dk1a requested a review from alvrs as a code owner May 12, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant