fix(cli): fix custom world deployment #3700
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployCustomWorld
returnsstateBlock
that is at world contract creation, but that is before initialization or ownership transferCurrently deploying a new customWorld doesn't work because
ensureNamespaceOwner
gets this earlystateBlock
and doesn't see the updated ownershipIn addition to the fix I add an e2e test for a simple CustomWorld identical to the normal world, to test that
deployCustomWorld
works at all (you can see it fail if you revert the fix)