Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pushing data to server if no url is given #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent pushing data to server if no url is given #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66354fe
Prevent pushing data to server if no url is given
FlorianBT Oct 29, 2015
196f033
Proper check for file path
FlorianBT Oct 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crashdumper/CrashDumper.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class CrashDumper
* @param stage_ (flash target only) the root Stage object
*/

public function new(sessionId_:String, ?path_:String, ?url_:String="http://localhost:8080/result", closeOnCrash_:Bool = true, ?customDataMethod_:CrashDumper->Void, ?postCrashMethod_:CrashDumper->Void, ?stage_:Dynamic)
public function new(sessionId_:String, ?path_:String="./", ?url_:String="http://localhost:8080/result", closeOnCrash_:Bool = true, ?customDataMethod_:CrashDumper->Void, ?postCrashMethod_:CrashDumper->Void, ?stage_:Dynamic)
{
hook = Util.platform();

Expand Down Expand Up @@ -184,7 +184,7 @@ class CrashDumper
CACHED_STACK_TRACE = getStackTrace();

#if !flash
doErrorStuff(e); //easy to separately override
doErrorStuff(e, path != null && path != "", url != null && url != ""); //easy to separately override
#else
doErrorStuffByHTTP(e); //minimal flash error report
#end
Expand Down Expand Up @@ -262,7 +262,8 @@ class CrashDumper
f.close();

var sanityCheck:String = File.getContent(path + pathLogErrors + logdir + "_error.txt");

trace("Dumpfile saved: \n" + FileSystem.fullPath(uniqueErrorLogPath+ "_error.txt"));

//write out all our associated game session files
for (filename in session.files.keys())
{
Expand Down