Repository navigation
feat(tool): offer an email link on files we can't explain - #25
Merged
Merged
Conversation
A crash or an unreadable file told the person it may be damaged and left it there, and telemetry can't say what made the file. The failed file card now offers an email with the reason, format, size and browser filled in. Only for failures we can't account for: refused formats and sizes explain themselves, and a browser read error has its own advice. The email never carries the file name, and says no attachment is needed, because the privacy page says we never see a file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The failed file card offers an email link, but only for failures we can't explain.
<CardReview> failed This file could not be read. {reason} Nothing was changed... + if isUnexplained(entry.reason) + Want us to look into it? <a mailto> Email hello@metastrip.appcrash: Error,unreadable: pdf,empty_output: pngcrash: NotFoundError,crash: NotReadableErrortoo_large,recognised: tiff,unsupported_typeThe email opens in the person's own mail app, pre-filled:
No file name, and no request for the file, because the privacy page says we never see one.
failure_report_clickedcounts clicks, not sent emails.Evidence
After: built site in headless Chrome, desktop and phone, with real files:
317 tests pass, typecheck and lint clean. Merged locally with #24: no conflicts, tests pass.
Not tested: the click event in a real browser, or a message actually reaching the inbox.
metastrip.apphas iCloud MX records.Merge Danger
Door: two-way
Blast Radius: failed-card
Only appears on the failed file card, so most sessions never see it. Merge #24 first, so emails carry the crash step.