Don't set quantizers as fields #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2020
AdamHillier
approved these changes
Apr 27, 2020
lgeiger
force-pushed
the
no-quantizer-fields
branch
from
d01a683 to
229fae7
Compare
I rebased it. Let's see what CI thinks |
lgeiger
commented
Apr 27, 2020
lgeiger
force-pushed
the
no-quantizer-fields
branch
from
f920f57 to
8e1de9c
Compare
AdamHillier
added
bug
AdamHillier
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #148
I think I'd be in favour of changing the behaviour of
zookeeper.Fieldto have the same semantics as@propertyas described in #148 (comment) instead of merging this PR, but for now this should provide a fix.