Handle nullable route binding columns - #299
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A model whose binding column is nullable (say
{post:slug}whereslugis nullable) produced arguments typedstring | null, and the generatedurl()method then failed to compile:applyUrlDefaults()only takesUrlDefaults | undefined, and.toString()was called on a value that might be null.Null is now dropped from the scalar argument forms, since a URL can never carry a null segment, so passing null directly is a type error. Objects keep the nullable column so a model can still be passed straight through, and the generated body sends the value through a new
requireParameter()helper that throws if it really is null. The check runs after the??fallback, so URL defaults still win.