Resolve middleware aliases when inferring URL defaults - #295
Merged
joetannenbaum merged 4 commits intoSep 9, 2026
Merged
Conversation
lazerg
force-pushed
the
fix/issue-294-middleware-alias-url-defaults
branch
from
August 7, 2026 00:09
6a6e09c to
2c6381c
Compare
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Middleware aliases only reach the router when the HTTP kernel is resolved, and
php artisan wayfinder:generatenever resolves it. A group written as->middleware(['auth', 'organization.user'])therefore hands Wayfinder the raw alias string,class_exists()on it fails, and whateverURL::defaults()the middleware sets gets missed, so the parameter stays required in the generated route.The command now resolves the kernel before walking the routes. That sync overwrites middleware groups instead of merging into them, so anything a service provider already pushed onto a group is captured first and re-applied afterwards.
The test is phpunit rather than vitest because the workbench can't reproduce the bug: Testbench boots the HTTP kernel itself, so aliases are already synced there and a workbench route would pass with or without the fix.
Closes #294