Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fixed type error caused by route $action error getting #432

Closed
wants to merge 0 commits into from

Conversation

KanekiYuto
Copy link

This error message appeared in my use.
9ad5e412a910764ada63ad1af34ec6ce
After checking, I found that the action obtained was an empty object because the following routing method was used.
1bcc1f1ab67cfd4e205090bdaade45eb
This data is incorrectly stored as an empty object in the Recorders/SlowRequests file
88cd6ac5cfc44eb4cd9cfd3c73da942f
So I provided a temporary patch to fix the error of not getting what I expected.
My English is not that good, so please understand if there is a mistake, thank you.

@taylorotwell taylorotwell marked this pull request as draft December 17, 2024 15:04
@KanekiYuto
Copy link
Author

fb0b703
I have supported the internationalization of pulse, which can now be used in English, Chinese (simplified), Chinese (Traditional)
You only need to run the following command to generate the file
php artisan pulse:lang-publish

@KanekiYuto KanekiYuto marked this pull request as ready for review December 17, 2024 15:27
@taylorotwell taylorotwell marked this pull request as draft December 17, 2024 20:22
@timacdonald
Copy link
Member

@KanekiYuto, can you please revert the internationalization commit (fb0b703) and send that in a new pull request?

We will need individual PRs for the fix and the language feature.

@timacdonald
Copy link
Member

@KanekiYuto, I've just tried to make this error happen with the routing method you have been using.

I created a test (https://github.com/laravel/pulse/pull/433/files) which seems to be passing.

Can you please create a minimal reproduction for this issue and we take a closer look?

laravel new bug-report --github="--public"

@KanekiYuto
Copy link
Author

@KanekiYuto,您能否恢复国际化提交(fb0b703)并在新的拉取请求中发送它?

我们需要单独的公关修复和语言功能。

yes,i need.

@KanekiYuto
Copy link
Author

@KanekiYuto,我刚刚尝试使用您一直使用的路由方法导致出现此错误。

我创建了一个测试(https://github.com/laravel/pulse/pull/433/files),它似乎通过了。

您能否针对此问题打造一款最小的复制品,以便我们仔细查看?

laravel new bug-report --github="--public"

I am trying to reproduce this error, and I will confirm and reproduce it with a new repository later

@KanekiYuto
Copy link
Author

@timacdonald After my repeated verification, I found that the error was caused by the incorrect generation of the routing cache file routes-v7.php. After updating to the latest laravel version, this problem seemed to disappear

@KanekiYuto
Copy link
Author

@timacdonald经过我的反复验证,发现该错误是由于路由缓存文件 routes-v7.php 生成不正确导致的,在更新到最新的 laravel 版本后,这个问题似乎消失了

However, I still recommend providing a compatible type option to avoid errors

@timacdonald
Copy link
Member

Thanks for checking that out for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants