[14.x] Job expiration based on job timeout, remove the need for retry_after - #61485
Open
SjorsO wants to merge 11 commits into
Open
[14.x] Job expiration based on job timeout, remove the need for retry_after#61485SjorsO wants to merge 11 commits into
retry_after#61485SjorsO wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last attempt at trying to get #61158 merged, this time targeting the next major release.
I'm aware this is a risky PR. It modifies core queue behavior, which is rock solid apart from the
retry_afterquirks. Still, I think the juice is worth the squeeze. It has worked for everything I've tested, it's backwards compatible, it removes a footgun in queued jobs, and it removes the need to explain the confusingretry_afterconcept in the docs.This PR is mostly beneficial for projects that have increased their
retry_after, which in my experience is common. I've worked on multiple projects whereretry_afterwas set to 1 hour.