Skip to content

[12.x] Update schema dump to use new MySQL SSL disable flag #55758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: 12.x
Choose a base branch
from

Conversation

ziadoz
Copy link
Contributor

@ziadoz ziadoz commented May 16, 2025

#55683 allowed SSL to be disabled when Laravel imports schema SQL. However, the --ssl=off flag was deprecated in 8.0.26 and removed in MySQL 8.0.40: Error: [ERROR] unknown variable 'ssl=off'.

This PR checks the MySQL version and uses the newer --ssl-mode=DISABLED for newer versions.

https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-26.html#mysqld-8-0-26-deprecation-removal
https://dev.mysql.com/doc/relnotes/mysql/8.4/en/news-8-4-0.html#mysqld-8-4-0-deprecation-removal
https://dev.mysql.com/doc/refman/8.4/en/connection-options.html#option_general_ssl-mode

An alternative to this might be a generic LARAVEL_LOAD_OPTS= env var that allows any custom options/flags to be added to the load command.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant