Eloquent cursor pagination doesn't apply global scopes correctly with unions #55751
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsvdanker
force-pushed
the
fix-eloquent-union-cursor-pagination-with-global-scopes
branch
from
d1d764e to
ad7bd37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using:
the global scopes are not applied correctly to the union queries, resulting in to little columns in the resulting query.
This causes either an error from the database that the number of columns / bindings have a mismatch (SQLite) or the bindings are applied to the wrong columns (SQL Server).
When using
toBase()on the union query this issue goes away.I don't know what the right moment would be to
applyScopeson the union query so don't know how to work on a fix for this issue.