Replace the dead env var replace action with delete - #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
environment:variables --action=replacecalledPUT /environments/{env}/variables, which the API removed. It was swapped for an atomicPOST /variables/delete, and nothing in the CLI used it.--action=deletenow takes its place.--keyaccepts a comma-separated list, and interactively you pick from the environment's existing keys. Deleting goes throughconfirmDestructive(), so it needs--forcewhen non-interactive.Kept this on the existing
--actionoption rather than adding a command, since a delete verb would have meant the first three-part command name in the CLI.