Fix bucket key secret never being returned - #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API returns a bucket key's secret as
access_key_secret, but the DTO readsecret_access_key. The null coalesce swallowed it, sosecretAccessKeywas always null and there was no way to get a key's secret out of the CLI.While in there,
bucket-key:createandbucket-key:getnow print the access key ID and secret, masked unless you pass--show-sensitive, the same wayauth:tokenhandles API tokens. Creating a key and not being shown the credentials was the main thing that made this worth reporting.There were no bucket key tests, which is why the wrong field name went unnoticed: the only coverage built the DTO from its PHP property names and never went through
createFromResponse(). Added tests that use real API response fixtures.