Mask API tokens in auth:token --list - #200
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth:token --listprinted saved API tokens in full, in the table and in the JSON. Every other secret in the CLI is masked by default, and this one is the most valuable of the lot:--listis documented with-n, which means JSON, so a live credential ends up in CI logs and agent transcripts from a command whose job is just to name the source of each token.Tokens now show as
*****plus their last four characters, which is enough to tell apart two tokens for the same organization.--show-sensitiveprints them in full.The masking elsewhere runs through DTO transformers, but this command built a raw array, so nothing applied. It now builds an
ApiTokenDTO, which also keeps--show-sensitiveworking.