Fix self-update 404 - #198
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloud self-updatealways failed with a 404. We configured the updater to useGithubReleasesStrategy, which builds its download URL asreleases/download/{version}/{pharName}, but nothing ever callssetPharName(), so the URL had no filename on the end.Switched to Laravel Zero's default
GithubStrategy, which downloadsbuilds/cloudfrom the tagged commit and fills in the filename itself.release.shalready commits the binary before tagging, so every tag has it.Verified by building a phar stamped v0.5.0 and running
self-updateagainst it, which correctly pulled down v0.5.1.Note that anyone on v0.5.1 or earlier still cannot self-update to the release carrying this fix, since the broken updater is the one doing the work. They will need to reinstall once.
Closes #196