Scope form fields per resource, and stop retrying requests that cannot succeed - #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds scoping to Form. Fields defined inside withScope() are namespaced, and ship now creates each nested resource (database cluster, schema, websocket cluster, websocket app) in its own scope. The resolver keeps the unscoped field name so API errors still map back to the right prompt, and scoped fields no longer read the command's own options. Unscoped fields are unchanged, so the other 20 commands behave exactly as before.
loopUntilValid also gives up now when the same failure repeats and no error field has a prompt behind it, printing "Fix the error above, then run again." An error the API does not tie to a field, like "The selected type is not available on your plan", used to replay the same request 20 times before dying on "Maximum attempts reached". Loops that wait out a transient error opt out through a new shouldRetry argument: ship's environment update and both database-cluster:delete loops. Errors are cleared after a successful attempt too, so a failure early in a run no longer leaks into the next loop.