Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve type error in 'setData' for 'remember' parameter #453

Closed
wants to merge 1 commit into from

Conversation

koficoud
Copy link

@koficoud koficoud commented Jan 23, 2025

Fixed a type error in Login.tsx (line 81) where setData was being called with a boolean value (e.target.checked) for the remember parameter, which expected a value of type false.

Solution: Adjusted the logic or type definition to ensure compatibility between the value passed (boolean) and the expected type for the remember parameter.

resources/js/Pages/Auth/Login.tsx:81:53 - error TS2345: Argument of type 'boolean' is not assignable to parameter of type 'false'.

81 setData('remember', e.target.checked)`

@taylorotwell
Copy link
Member

Where would remember always expect false? Something about this doesn't seem correct. 🤔

@koficoud
Copy link
Author

Where would remember always expect false? Something about this doesn't seem correct. 🤔

Hi Taylor,

Thank you for your feedback and for taking the time to review my PR. I understand that something about the logic for the remember parameter didn't seem correct. Could you clarify if the parameter is intended to strictly expect false, or if it should support boolean values (true or false)?

I’d be happy to adjust my implementation to align with the intended behavior and resubmit a more accurate fix.

Thanks again for the opportunity to contribute to the project. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants