Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always prompt for optional features #423

Closed

Conversation

reibengu
Copy link

@reibengu reibengu commented Oct 2, 2024

Started a new project using Laravel Bootcamp and ran php artisan breeze:install react as instructed.

Noticed the installer doesn't prompt for optional features like TypeScript support or Dark mode when stack is set.
It led to confusion and forced me to recreate the project to include these features.

Changed logic to always prompt for optional features and select as default the arguments passed directly like php artisan breeze:install react --typescript.

It might require an extra argument --no-interaction for cases when this is run from another script, similar to what composer uses (that can also be a global trait of commands).

@reibengu
Copy link
Author

reibengu commented Oct 2, 2024

I can add --no-interaction to make the tests pass in case you approve the idea.

@crynobone
Copy link
Member

This break the current expected behaviour with PromptsForMissingArgument contract. You should provide breeze:install instead of providing any argument.

@reibengu
Copy link
Author

reibengu commented Oct 2, 2024

This break the current expected behaviour with PromptsForMissingArgument contract. You should provide breeze:install instead of providing any argument.

It's not related to PromptsForMissingInput at all, it's related to how the CLI is designed and if it should always ask for the optional arguments or not.

@taylorotwell taylorotwell reopened this Oct 2, 2024
@taylorotwell
Copy link
Member

We actually don't document passing arguments to this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants