-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic insertion of settings required for front-end integration #394
Conversation
@taylorotwell I couldn't find that code in config/app/.php. |
framework app config is this: If your laravel app cannot find So you don't need to add You can actually test this. Just create new laravel app without breeze. laravel new testproj
cd testproj
php artisan tinker
> config('app.frontend_url') Then it outputs = "http://localhost:3000" |
@askdkc |
I use laravel installer (less typing). If you look official documents throughly it also mention laravel installer
composer global require laravel/installer
laravel new example-app |
There is no problem if you create a project by Test these commands.
Output:
|
Dear Laravel Breeze Team,
Hi, let me send my PR here.
What I did
Fixed to automatically append the code needed for API integration with the frontend.
When the command
php artisan breeze:install
is executed,'frontend_url' => env('FRONTEND_URL ', 'http://localhost:3000 '),
is appended to the end ofconfig/app.php
.Benefit for developers
In the current version,
FRONTEND_URL
is appended to the.env
file when thephp artisan breeze:install
command is executed, but the code to read it'frontend_url' => env('FRONTEND_URL ', 'http://localhost:3000'),
must be added manually toconfig/app.php
.This is not clearly stated in the tutorial in the official documentation (https://laravel.com/docs/11.x/starter-kits) and is kind for developers.
This fix solves them automatically, so developers can implement user and email authentication without hesitation.
Best regards,
Seito Hriguchi