Remove Hash Facade from Authentication Controllers #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove the
Hash
facade from the authentication controllers, specifically whereHash::make($request->string('password'))
is used for password hashing. This change is made to avoid duplicate password hashing, as it is already handled in theUser
model. By doing so, we can ensure consistency and reduce redundancy in our codebase.Reasoning:
User
model simplifies maintenance and future updates to the hashing process.Implementation:
Hash::make($request->string('password'))
to$request->password
.Controllers Modified:
RegisteredUserController
(api, default and inertia )NewPasswordController
(default and inertia)