Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pilvo v4 support #39

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atymic
Copy link
Member

@atymic atymic commented Jun 17, 2021

Closes #28

@bobking256
Copy link

Still does not appear to support plivo/plivo-php ^4.3

@atymic
Copy link
Member Author

atymic commented Jun 25, 2021

As in, you get an error or it doesn't allow you to install?

@bobking256
Copy link

As in, you get an error or it doesn't allow you to install?

Correct. Won't install.

@atymic
Copy link
Member Author

atymic commented Jul 1, 2021

As in, you get an error or it doesn't allow you to install?

Correct. Won't install.

Please post the error

@bobking256
Copy link

bobking256 commented Jul 2, 2021

As in, you get an error or it doesn't allow you to install?

Correct. Won't install.

Please post the error

Here is error I am getting when trying to install:

Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires laravel-notification-channels/plivo ^2.3 -> satisfiable by laravel-notification-channels/plivo[v2.3].
- laravel-notification-channels/plivo v2.3 requires plivo/plivo-php ^1.1 -> found plivo/plivo-php[v1.1.0, ..., v1.1.7] but it conflicts with your root composer.json require (^4.18).

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Also, when including in app.php NotificationChannels\Plivo\PlivoServiceProvider::class I immediately get NotificationChannels\Plivo\PlivoServiceProvider::class not found. File is there.

@atymic
Copy link
Member Author

atymic commented Jul 3, 2021

Could you send me your composer.json?

@bobking256
Copy link

Could you send me your composer.json?

{
"name": "laravel/laravel",
"type": "project",
"description": "The Laravel Framework.",
"keywords": ["framework", "laravel"],
"license": "MIT",
"require": {
"php": "^7.3|^8.0",
"bugsnag/bugsnag-laravel": "^2.0",
"fideloper/proxy": "^4.4",
"fruitcake/laravel-cors": "^2.0",
"guzzlehttp/guzzle": "^7.0.1",
"inertiajs/inertia-laravel": "^0.3.5",
"laravel/framework": "^8.12",
"laravel/jetstream": "^2.3",
"laravel/sanctum": "^2.6",
"laravel/tinker": "^2.5",
"laravel-notification-channels/plivo": "^2.3",
"plivo/plivo-php": "^4.18",
"tightenco/ziggy": "^1.0"
},
"require-dev": {
"facade/ignition": "^2.5",
"fakerphp/faker": "^1.9.1",
"laravel/sail": "^1.0.1",
"mockery/mockery": "^1.4.2",
"nunomaduro/collision": "^5.0",
"phpunit/phpunit": "^9.3.3"
},
"autoload": {
"psr-4": {
"App\": "app/",
"Database\Factories\": "database/factories/",
"Database\Seeders\": "database/seeders/"
}
},
"autoload-dev": {
"psr-4": {
"Tests\": "tests/"
}
},
"scripts": {
"post-autoload-dump": [
"Illuminate\Foundation\ComposerScripts::postAutoloadDump",
"@php artisan package:discover --ansi"
],
"post-root-package-install": [
"@php -r "file_exists('.env') || copy('.env.example', '.env');""
],
"post-create-project-cmd": [
"@php artisan key:generate --ansi"
]
},
"extra": {
"laravel": {
"dont-discover": []
}
},
"config": {
"optimize-autoloader": true,
"preferred-install": "dist",
"sort-packages": true
},
"minimum-stability": "dev",
"prefer-stable": true
}

@atymic
Copy link
Member Author

atymic commented Jul 3, 2021

You're not actually installing this PR just the main version of the package. you'll have to set up a composer repo to my gh and select the branch to do so.

@bobking256
Copy link

You're not actually installing this PR just the main version of the package. you'll have to set up a composer repo to my gh and select the branch to do so.

Sorry to be such a bother, but can you write down steps to do this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not support "plivo/plivo-php": "^4.3"
2 participants