fix: role reversal for tool messages in user simulator (Python)#224
Open
Aryansharma28 wants to merge 4 commits intomainfrom
Open
fix: role reversal for tool messages in user simulator (Python)#224Aryansharma28 wants to merge 4 commits intomainfrom
Aryansharma28 wants to merge 4 commits intomainfrom
Conversation
Align Python reverse_roles() with JS messageRoleReversal(). Tool messages are now summarized as plain text instead of being kept as-is or dropped, preventing consecutive assistant roles and lost tool context in the user simulator's conversation history. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
drewdrewthis
left a comment
drewdrewthis
left a comment
There was a problem hiding this comment.
@Aryansharma28 tests
Align Python reverse_roles() with JS messageRoleReversal(). Tool messages are now summarized as plain text instead of being kept as-is or dropped, preventing consecutive assistant roles and lost tool context in the user simulator's conversation history. - Use isinstance() instead of type() == dict - Add 30 unit tests covering all helper functions and edge cases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
drewdrewthis
left a comment
drewdrewthis
left a comment
There was a problem hiding this comment.
The title of the PR doesn't not say that it is summarizing tool calls. this is actually a bit concerning and I think needs further justification?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Python reverse_roles() with JS messageRoleReversal(). Tool messages are now summarized as plain text instead of being kept as-is or dropped, preventing consecutive assistant roles and lost tool context in the user simulator's conversation history.