Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass model and cost so that langfuse can show cost #13117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

obadakhalili
Copy link

Summary

Dify's integration with Langfuse doesn't show generation cost.

Closes #10684 (and probably more similar issues).

Details

The code that transforms Message into dict to attach as message_data in trace_info object doesn't include total_price and model_id, which are necessary for Langfuse to calculate the cost. The same is true about the code responsible for instantiating a Message object from a dict.

Some things to be aware of:

  • I can pass the model ID alone, and Languse will use this with the rest of the available information to infer the cost, but I thought that it would be better to pass the cost if it is available. Should this be reconsidered?
  • usage_details is deprecated

Screenshots

Before:
image

After:
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 💪 enhancement New feature or request labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Langfuse monitoring platform cannot count the cost of the model in the parameter extractor
1 participant