Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update Firecrawl API parameters and default settings #13082

Merged
merged 1 commit into from
Jan 29, 2025
Merged

refactor: Update Firecrawl API parameters and default settings #13082

merged 1 commit into from
Jan 29, 2025

Conversation

ftonato
Copy link
Contributor

@ftonato ftonato commented Jan 27, 2025 •
edited
Loading

Summary

Update Firecrawl API parameters and default settings

Tip

Resolves #13097

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@mogery
Copy link

mogery commented Jan 27, 2025

LGTM (Firecrawl end)

@ftonato ftonato marked this pull request as ready for review January 27, 2025 18:32
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 27, 2025
@ftonato
Copy link
Contributor Author

ftonato commented Jan 27, 2025

Hello @crazywoola, can you take a look on it?

crazywoola
crazywoola approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however please link an existing issue or creating one :)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 28, 2025
@ftonato
Copy link
Contributor Author

ftonato commented Jan 28, 2025

LGTM, however please link an existing issue or creating one :)

@crazywoola updated, can we merge?

@crazywoola crazywoola merged commit d0a2108 into langgenius:main Jan 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter update for use of Firecrawl V1 API
3 participants
@ftonato @mogery @crazywoola