Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add agent thinking content display of deepseek R1 #12949

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Jan 22, 2025

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

fix #12891

It will wrap the thinking content with markdown's quote

Screenshots

Before After
9644ea12add88b4e255580be88331a8 f21c6f1ab9400bec78576dd09a37678

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime 🤖 feat:agent Agent related topics labels Jan 22, 2025
@crazywoola crazywoola requested a review from laipz8200 January 24, 2025 02:06
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 24, 2025
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazywoola crazywoola merged commit 59b3e67 into langgenius:main Jan 24, 2025
6 checks passed
@CracKerMe
Copy link

CracKerMe commented Jan 25, 2025

Thank you for your efforts, but I am curious about the DeepSeek-R1 deployed by Ollama. The tag display is still incorrect. Will there be continuing repair plans?

image

@hjlarry
Copy link
Contributor Author

hjlarry commented Jan 26, 2025

Thank you for your efforts, but I am curious about the DeepSeek-R1 deployed by Ollama. The tag display is still incorrect. Will there be continuing repair plans?

My Ollama doesn't have enough GPU power to run DeepSeek-R1. Perhaps someone else could implement this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 feat:agent Agent related topics ⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added support for including the reasoning process in the output of Reasoning Model.
4 participants