Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(1.0): improve some environment variables #12814

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Jan 17, 2025

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

change list

  • all the ENDPOINT_URL_TEMPLATE should be http://localhost:5002/e/{hook_id} , not http://localhost/e/{hook_id}
  • all the MARKETPLACE_API_URL should be https://marketplace.dify.ai, not https://marketplace-plugin.dify.dev
  • CONSOLE_API_URL, CONSOLE_WEB_URL, MARKETPLACE_ENABLED, MARKETPLACE_API_URL, ENDPOINT_URL_TEMPLATE are already in the shared-env, remove them from special container env
  • other modify of docker-compose.yaml is auto generated

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 17, 2025
@crazywoola crazywoola added this to the 1.0 milestone Jan 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2025
@crazywoola crazywoola merged commit 60427f1 into langgenius:plugins/beta Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants