Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1.0): invoke llm raise error #12753

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix(1.0): invoke llm raise error #12753

merged 2 commits into from
Jan 22, 2025

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Jan 15, 2025

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

when select a model of a tool, the completion_params will be None, will raise error:
c74c5b25953c05e8db1b28049ba0995

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 15, 2025
@crazywoola crazywoola added this to the 1.0 milestone Jan 21, 2025
@Yeuoly
Copy link
Collaborator

Yeuoly commented Jan 21, 2025

A better solution is to avoid completion_params to be None in frontend I think, how do you think?

@hjlarry
Copy link
Contributor Author

hjlarry commented Jan 22, 2025

A better solution is to avoid completion_params to be None in frontend I think, how do you think?

That's correct, the changes have now been made on the frontend.

Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
@Yeuoly Yeuoly merged commit 5f0fa38 into langgenius:plugins/beta Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants