refactor: Update Firecrawl to use v1 API #12574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated API endpoints from v0 to v1 for scrape and crawl methods. - Enhanced error handling in `scrape_url` and `check_crawl_status` methods. - Introduced helper methods _extract_common_fields and _format_crawl_status_response for better code organization and readability. Closes: langgenius#12571
|
From Firecrawl v1 perspective, looks good! |
dosubot
bot
added
the
size:M
crazywoola
previously approved these changes
Jan 12, 2025
|
Please fix the tests and run |
|
Hello @crazywoola, I’ve made the changes, but I couldn’t run the workflow or the pytest tests in the project directory locally. Could you run the workflow on this PR to check the results? |
|
UPDATE: I still need to make some changes. I’ll let you know once they’re done. |
dosubot
bot
added
size:L
nickscamara
reviewed
Jan 14, 2025
nickscamara
reviewed
Jan 14, 2025
nickscamara
suggested changes
Jan 14, 2025
nickscamara
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
LGMT (from Firecrawl side) - @crazywoola mind taking another look at it and testing e2e to make sure it is good? Thank you!
crazywoola
previously approved these changes
Jan 22, 2025
|
Hello it seems it didn't pass the tests. |
Hello, I am going to take a look again 🤦 @crazywoola Can you run again the pipeline? |
ftonato
force-pushed
the
refactor/update-firecrawl-api-to-v1
branch
from
390a9f3 to
a3b1e6c
Compare
crazywoola
approved these changes
Jan 23, 2025
|
Merged ：） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
scrape_urlandcheck_crawl_statusmethods._extract_common_fieldsand_format_crawl_status_responsefor better code organization and readability.Resolves #12571