Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify some exception catch code #12246

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

acelyc111
Copy link
Contributor

@acelyc111 acelyc111 commented Dec 31, 2024

Summary

In #11955, some exceptions are changed to derive from ValueError, so the related exception catch code can be simplifed.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 31, 2024
@acelyc111 acelyc111 changed the title feat: throw AppInvokeQuotaExceededError when rate limited feat: throw 429 instead of 500 when rate limited Jan 2, 2025
@crazywoola crazywoola requested a review from laipz8200 January 2, 2025 01:56
@acelyc111 acelyc111 changed the title feat: throw 429 instead of 500 when rate limited feat: return 429 instead of 500 when rate limited Jan 2, 2025
@laipz8200
Copy link
Member

We've changed those exceptions to ValueError in #11955.

@acelyc111
Copy link
Contributor Author

acelyc111 commented Jan 2, 2025

We've changed those exceptions to ValueError in #11955.

So all code like except (ValueError, AppInvokeQuotaExceededError) as e: can be simplified to except ValueError as e:, right?

@laipz8200
Copy link
Member

We've changed those exceptions to ValueError in #11955.

So all code like except (ValueError, AppInvokeQuotaExceededError) as e: can be simplified to except ValueError as e:, right?

Yes.

@acelyc111 acelyc111 changed the title feat: return 429 instead of 500 when rate limited refactor: simplify some exception catch code Jan 2, 2025
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 2, 2025
@laipz8200 laipz8200 merged commit c135967 into langgenius:main Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants