Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Skip Redis operations if RateLimit is disabled #12226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

acelyc111
Copy link
Contributor

@acelyc111 acelyc111 commented Dec 30, 2024

Summary

RateLimit uses Redis as the backend implementation, it uses Redis commands like EXISTS, GET, EXPIRE, EXEC and etc. However, the Redis cluster or some proxy-based Redis don't support the EXEC command, even if we didn't enable RateLimit, it still fail.

This patch skip the useless Redis operations if RateLimit is disabled.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant